golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.38k stars 17.7k forks source link

x/pkgsite: API for pkg.go.dev #36785

Open rhcarvalho opened 4 years ago

rhcarvalho commented 4 years ago

Prior to pkg.go.dev, godoc.org has had a JSON API that can be used to, among other things, discover importers of a given package.

Example: https://api.godoc.org/importers/golang.org/x/net/html

Given that pkg.go.dev does a much better job at tracking importers thanks to Go Modules and the Module Proxy, it would be nice if the community could get access to a public API similar to that of godoc.org.

julieqiu commented 4 years ago

@rhcarvalho - it would be helpful to get a sense of what your current use cases are for api.godoc.org, and feature requests are for an API for pkg.go.dev.

It sounds like getting the importers for a package is one of them. With pkg.go.dev being module aware, what specific information about importers would be useful to surface via an API?

For example:

Additionally, what other information would be useful to you to surface via an API?

/cc @tbpg who has also mentioned wanting an API for pkg.go.dev

rhcarvalho commented 4 years ago

Without much thought, having an API to answer the more specific question "what are the importers of a specific version of a package" would make plausible to derive the answer to the other items in your list.

At the moment I consume the godoc.org API and scrape data from pkg.go.dev to answer the question "who uses my package". As far as I can tell the data in the "Imported By" go.dev tab is unrelated to the version of the package I'm currently browsing.

Here are the other endpoints in the GoDoc API: https://github.com/golang/gddo/blob/7365cb292b8bfd13dfe514a18b207b9cc70e6ceb/gddo-server/main.go#L901-L904

So if we need a more specific request, here it is:

api.go.dev MVP

tbpg commented 4 years ago

Another endpoint idea (standalone or as part of a set of info returned for a module): available versions of a given module.

myitcv commented 4 years ago

@tbpg

Another endpoint idea (standalone or as part of a set of info returned for a module): available versions of a given module.

Shouldn't people use cmd/go for that? Not least because of the fall-through semantics of the go env GOPROXY` variable. Noting https://github.com/golang/go/issues/37367

julieqiu commented 4 years ago

What information beyond https://proxy.golang.org/<module>/@v/list would be provided by that endpoint?

tbpg commented 4 years ago

Shouldn't people use cmd/go for that? Not least because of the fall-through semantics of the go env GOPROXY` variable. Noting #37367

There are some cases where cmd/go might not be available and a normal web API would be helpful. I think it's reasonable to assume pkg.go.dev will only return the modules/versions it knows about.

What information beyond https://proxy.golang.org/<module>/@v/list would be provided by that endpoint?

None. That works. :)

myitcv commented 4 years ago

There are some cases where cmd/go might not be available and a normal web API would be helpful

I'd be wary of encouraging tool authors to query pkg.go.dev/a proxy directly. Because it could well introduce skew compared to the answers from cmd/go.

adamdecaf commented 4 years ago

In my use-case I don't want to execute cmd/go binaries as I just want to grab some metadata (i.e. detected license of all dependencies) from a dozen modules and organize it on a webpage. If I need local clones of those modules it really complicates this internal tool.

myitcv commented 4 years ago

In https://github.com/golang/go/issues/37952 I raised the question of whether module/package license file information could be surfaced in the output of cmd/go list. Following a conversation on yesterday's golang-tools call, we concluded that doing so would be a bad idea; reasons summarised in https://github.com/golang/go/issues/37952#issuecomment-611527845.

@ianthehat instead suggested exposing the information via a pkg.go.dev API, leveraging the fact that the content and presentation on pkg.go.dev has already jumped through the relevant legal hoops.

This comment is therefore to explicitly request that we include license file information in the API. Thank you!

tiegz commented 4 years ago

👋 Thanks for all the new Go tools like pkg.go.dev, they're super useful. Some input on this topic from the perspective of Libraries.io:

Currently to get the publish times for all versions, you have to make N+1 requests: one for @v/list and then @v/xxx.info for each version and grab the "Time" value for each one. Assuming it's difficult to change the Go proxy spec, an API endpoint that returns all versions with metadata would be really nice.

Anyone know if there are plans to fix this?

jba commented 4 years ago
  • As far as I can tell the data in the "Imported By" go.dev tab is unrelated to the version of the package I'm currently browsing.

Anyone know if there are plans to fix this?

No immediate plans. We currently gather that information from import statements in the code, so there is no version information attached. The go.mod file doesn't have all the version information we need.

So we understand it's an approximation and we want to fix it, but it's going to take some time.

pombredanne commented 4 years ago

@julieqiu my use for an API would be to:

  1. search and list packages
  2. for a package, access all the information as available for a given package in each of the tabs, such as here https://pkg.go.dev/github.com/gin-gonic/gin?tab=licenses ... basically everything that is available as HTML in the frontend https://github.com/golang/pkgsite/tree/master/internal/frontend should be available in a JSON api
pombredanne commented 4 years ago

@julieqiu oh and please do not retire http://api.godoc.org/packages unless there is an alternative!

eclipseo commented 4 years ago

it would be helpful to get a sense of what your current use cases are for api.godoc.org, and feature requests are for an API for pkg.go.dev.

As a downstream package maintainer for Fedora, I'm also interested in an API. We have our own tool, Anitya, to track package releases, but it was not designed to track GIT commits. And many Go packages still don't publish version. So any information about latest published commit, with info like date of the commit, new dependencies, would be very helpful. I would gather data from the API in Python and compare it to the latest version we have for a given package.

I'm also interested in getting the License info, so we could find recursively all the licenses used in a static binary.

pombredanne commented 4 years ago

and BTW my general use case is for https://github.com/nexB/scancode-toolkit and related projects to provide my users with license, origin and dependencies details. And for https://github.com/nexb/vulnerablecode where we provide vulnerabilities details.

StevenACoffman commented 4 years ago

My present use case is discovering major version upgrades. Currently, we have to scrape pkg.go.dev. An alternative to pkg.go.dev API, would be if there were an "official" way (via go list for example) in the future to retrieve the latest major version of a module, we could use it in tools like go-mod-upgrade and icholy/gomajor but that would depend on golang/go#40357 (deprecated notification) and golang/go#40323 (notify about newer major versions). Thanks!

icholy commented 4 years ago

@StevenACoffman I've updated gomajor to find newer versions using the module proxy. The performance is acceptable.

0x2b3bfa0 commented 4 years ago

My use case is importing modules/packages to another package manager (Guix) where builds are completely reproducible and monolithic vendoring is strongly discouraged. Having a JSON API would simplify the obtention of metadata like licenses, brief package descriptions, dependencies and hashes.

jba commented 3 years ago

We'll be keeping api.godoc.org around for a while.

jba commented 3 years ago

Our current plan is to keep api.godoc.org around until we have a suitable replacement.

myitcv commented 3 years ago

/search/: matches the functionality of https://pkg.go.dev/search?q=hello, returns JSON instead.

Building on this point, it would be great if a real-time fuzzy search API were exposed. That way command line tools could wrap/use this.

restuwahyu13 commented 3 years ago

Hello everyone, is there a public API for pkg.go.dev ?, if there is I want to use it for my package library i.e. gopack-cli, for now I'm using the go doc API, for downloading go package library from gopack-cli .

jba commented 3 years ago

@restuwahyu13 , keep using api.godoc.org.

restuwahyu13 commented 3 years ago

But is api.godoc.org the same as pkg.go.dev sir @jba ?

fzipp commented 3 years ago

@restuwahyu13 pkg.go.dev doesn't have an API yet, that's why this issue is open and not closed.

shellscape commented 3 years ago

Stopping by to ask that any first version of an API provide some means to glean the source code / repo location of a package that uses a vanity path/url/name.

guseggert commented 3 years ago

I have similar use cases as others, so I resorted to scraping the UI as well (:nauseated_face:), and put it behind an API/CLI: https://github.com/guseggert/pkggodev-client

aj-arena commented 2 years ago

The /packages api endpoint, https://api.godoc.org/packages, is returning {"error":{"message":"Internal Server Error"}} .

Has this endpoint been migrated?

tills13 commented 2 years ago

Seems like most api.godoc.org endpoints are erroring, currently?

e.g. https://api.godoc.org/packages, https://api.godoc.org/imports/github.com/goburrow/cache, etc.

I'm particularly interested in the imports endpoint. Has this moved somewhere else or is there a mirror I can use?

pombredanne commented 2 years ago

This is starting to be really problematic. @jba could someone kindly look into this? This is really looking bad

pombredanne commented 2 years ago

@julieqiu do you know what happened?

jba commented 2 years ago

Will get on this today.

pombredanne commented 2 years ago

@jba you rock... that's very kind of you! :bow:

pombredanne commented 2 years ago

Note that only alternative today would be to resort to extensive pseudo-random screen scraping of https://pkg.go.dev/search laced in with some extensive recursive hitting of https://index.golang.org/index to get a complete package picture. It can work if this is what is recommended, but it would feel a bit like it is 1999 all over again. ;) If anything and if that's the way to go, then at least I could create a common service that does this for everyone?

jba commented 2 years ago

api.godoc.org should be back up.

pombredanne commented 2 years ago

@jba this is responding but not doing anything for me:

$ wget https://api.godoc.org/packages
--2022-02-01 14:33:56--  https://api.godoc.org/packages
Resolving api.godoc.org (api.godoc.org)... 142.250.179.147, 2a00:1450:400e:80f::2013
Connecting to api.godoc.org (api.godoc.org)|142.250.179.147|:443... connected.
HTTP request sent, awaiting response...

this stays there hanging waiting, no I/O nor CPU used.

pombredanne commented 2 years ago

@jba strike this out. It completed after a while! Thank you ++ :bow:

ZiViZiViZ commented 2 years ago

Prior to pkg.go.dev, godoc.org has had a JSON API that can be used to, among other things, discover importers of a given package.

Sorry for the stupid question but where are the documentations for using this "JSON API" that godoc.org had?

srenatus commented 2 years ago

@ZiViZiViZ https://github.com/golang/gddo/wiki/API

ZiViZiViZ commented 2 years ago

Thanks but this does not seem to have enough information. I am looking to be able to get the license for a package. I was hoping there is a way to do something like that:

 $ curl -s https://api.godoc.org/search?q=gopkg.in/yaml.v2@v2.4.0 |jq '.results[].license'
"Apache License 2.0"
tills13 commented 2 years ago

@ZiViZiViZ the way I accomplish this is by making a request to https://pkg.go.dev/gopkg.in/yaml.v2?tab=licenses and using an HTML parser to grab the license headers. (replace gopkg.in/yaml.v2 with whichever package you're looking for the license for)

ZiViZiViZ commented 2 years ago

Thank you. That is what I am doing right now but I thought there might be a better way to do this.

Alphare commented 2 years ago

I am part of the Software Heritage initiative to archive all versions of public code and packages.

I'm looking for a way of listing all go packages, planning then to download the source for each release. For example in the Rust ecosystem, crates.io has an API that allows us to get all the metadata for a known package and each of its releases, which is very practical.

It appears that there only exists https://api.godoc.org/packages which returns a single 300MB+ JSON file containing only URLs to the repositories of packages (and some import_count metric that is always 0), but nothing more. https://index.golang.org/index is not looking any different. Am I missing anything worthwhile that would help?

Thanks in advance.

seankhliao commented 2 years ago

please keep this issue on topic and refer questions to https://github.com/golang/go/wiki/Questions

shellscape commented 2 years ago

Rather than hiding what I'd consider a lot of really useful comments by folks (because I landed here for many of the same reasons they did, and there is extremely little available with regard to go package APIs) it would be infinitely more useful to explain to folks how to use the wiki for questions - or specify that tangential and related questions here are not welcome, and folks should seek the answers on the wiki. As it is now, that curt reply seems to imply that we should post questions on the wiki itself, which I doubt is what you're actually after.

The go team has been kicking this can for years, so users are naturally going to have a lot of questions. This reply https://github.com/golang/go/issues/36785#issuecomment-579820081 specifically asks users what features they're after in an API - thus the issue is fair game for feature-related questions. Go packages are the very last major ecosystem package registry to lack a comprehensive API and that which doesn't make its data readily available. Because of this, people are naturally going to have a myriad of questions about trying to access that data. I'd humbly ask @seankhliao to be a bit more gracious in your moderation of this issue.

golightlyb commented 2 years ago
rsc commented 2 years ago

For what it's worth, we have been running api.godoc.org as an unmonitored service (meaning we don't page people for it), approximately "best effort" although even that may be too generous. We discovered today that it has been down for 30+ days because the disk filled. Given that being down for a month was a non-issue, we've decided to leave it down.

The godoc.org redirects will continue to run (approximately forever), but api.godoc.org will no longer be accessible. Or rather it will continue to be inaccessible.

golightlyb commented 2 years ago

@rsc fair enough if this is the decision but the previous comment is mine, right at the start of that 30+ day period, saying it's down, and three people agreeing.

If this is the decision, again, fine - but I submit that it shouldn't be based on people not complaining because to be fair I raised this pretty much as soon as it happened and it was never fixed and didn't have a response (fair enough- priorities) so anyone saying the same thing wouldn't be adding anything, and nobody knew they had a 30ish day deadline to object

(I don't intend for this to sound harsh, just as a disagreement! 🙂)

Edit: as an aside that might be helpful for people with an interest in this, Google's experimental Open Source Insights has an API. I wasn't aware of it until recently but it could very well resolve this entire conversation.

shellscape commented 2 years ago

honestly this reflects pretty poorly on the entire team and the project in general. compared to other ecosystems and their package management, and user experience, the go community leaves a lot to be desired.

shellscape commented 2 years ago

Nice. Comment on the actions taken, or lack thereof, and get hidden as off-topic. If the team isn't open to polite and honest criticism, lock the topic.