x/pkgsite: licence not yet showing up after it was added to a module

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

124.04k stars 17.67k forks source link

x/pkgsite: licence not yet showing up after it was added to a module #40863

Closed gnuy closed 4 years ago

gnuy commented 4 years ago

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/gnuy/subdivx-get

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Screenshot

DeepinScreenshot_select-area_20200818120421

What did you do?

Created a Go project on GitHub without a license and added that license later. I'm filing this issue as recommended here.

What did you expect to see?

The license in the site being the MIT license.

What did you see instead?

The license in the site is still no legal advice

dmitshur commented 4 years ago

Version v0.0.0 (1a772ed) of the github.com/gnuy/subdivx-get module is being displayed in the screenshot you shared. That version does not have a LICENSE file:

https://github.com/gnuy/subdivx-get/tree/1a772eddf252/LICENSE (404)

The LICENSE file was added 2 hours ago in commit 2219d5c4.

It seems that this is working as intended. When pkg.go.dev starts displaying the newer version of the module, it should recognize the license.

/cc @julieqiu @jba @jamalc per owners.

julieqiu commented 4 years ago

I just refreshed the version. You should see that https://pkg.go.dev/github.com/gnuy/subdivx-get now has license MIT.