x/net/http2: graceful shutdown support to standalone HTTP/2 server

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

123.68k stars 17.62k forks source link

x/net/http2: graceful shutdown support to standalone HTTP/2 server #41418

Open soya3129 opened 4 years ago

soya3129 commented 4 years ago

This is a feature request which follows #4674.

HTTP/2 server only supports graceful shutdown when integrated with the standard library's HTTP Server: https://github.com/golang/net/blob/62affa334b73ec65ed44a326519ac12c421905e3/http2/server.go#L199

We have a use case where HTTP/2 server is used as a stand-alone server with ALTS instead of TLS as the security layer (https://cloud.google.com/security/encryption-in-transit/application-layer-transport-security?hl=en). It seems impossible to use the graceful shutdown feature currently even if we are willing to start a HTTP server (I could be wrong. Any idea will be very welcome!).

I think making the related functions public can easily fix the issue.

There is also some discussion around generalizing the graceful shutdown in https://github.com/golang/go/issues/4674#issuecomment-257562428 .

soya3129 commented 4 years ago

cc @birenroy, @ianswett

soya3129 commented 4 years ago

cc @neild

networkimprov commented 4 years ago

cc @fraenkel

fraenkel commented 4 years ago

How are you even creating a "standalone" http2 server?

soya3129 commented 4 years ago

Thanks for the attention! The standalone server calls ServeConn directly with a connection wrapped in ALTS. I was thinking if serverInternalState is public, users can call StartGracefulShutdown() directly, instead of implementing their own. Thanks!

fraenkel commented 4 years ago

Its not so simple. Regardless of where we could put StartGracefulShutdown(), the current code lacks most of the guards that are currently provided via http.Server. One such example is preventing new connections from being served once Shutdown is called. Exposing the current shutdown behavior just affects the current connections but does nothing to prevent new ones.

soya3129 commented 4 years ago

That's right! I totally agree that to implement a complete graceful shutdown, there would be much more work.

But for the standalone use case, it would be relatively easy for users to close listeners and make sure the server waits for existing connections to close. The hard/impossible part is to trigger GOAWAYs (Please correct me if I am wrong). startGracefulShutdown() does exactly that. Instead of calling it StartGracefulShutdown(), we could call it SendGracefulGoawayOnActiveConnections(). What do you think? Thanks!

soya3129 commented 4 years ago

Gentle ping. Thanks!

AlexanderYastrebov commented 3 years ago