Open hyangah opened 3 years ago
This is certainly plausible misbehavior, but did you by any chance have the go.mod file open in your workspace? That could have suppressed any reloading from on-disk changes.
I can of course try to reproduce, but thought I'd check this first :)
I didn't have the go.mod
file open (and reproduced it after making sure no file was open).
But another news: this initial workspace loading failure occurs only if I have the experimental workspace module feature enabled.
When it's not enabled, the initial workspace loading finishes and sends diagnostics about all the missing modules for imports.
I understand why this issue comes up--I think it's because running go mod tidy
doesn't actually modify the go.sum
file, since in a fresh clone, it should already be correct. (Technically this isn't true right now because the go.mod
file has to be tidy for both 1.16 and 1.17.) I'm not sure exactly how to address this issue, but maybe we need a quickfix option to re-run the workspace load with a user action?
Rather than adding a special reload workspace quick fix, we should improve the error message and make it clear that the load failed because of a lack of internet (downloading failed).
Change https://go.dev/cl/419500 mentions this issue: internal/lsp/cache: allow network whenever reloading the workspace
FWIW this is at least partially resolved by https://go.dev/cl/419500. Now a go mod tidy, or even just touch go.mod
, will resolve the errors.
We can still do a better job with error messages though.
What version of Go are you using (
go version
)?What did you do?
Due to bad network connection, initial workspace loading failed to download necessary dependencies. I manually ran
go mod tidy
and downloaded dependencies, but the error notification didn't go away.How to repro:
go clean -modcache
go mod tidy
manually from the terminalWhat did you expect to see?
go mod tidy
run.What did you see instead?
Sticky error notification & diagnostics.
gopls trace - ran go mod tidy manually around 7:23.