Closed bcmills closed 2 years ago
The playground defines a max snippet size of 64 KB. The snippet above is about twice as large.
The server returns status code 413, but the frontend displays the same "Server error; try again." for any non-200 status code.
64 KB may be a reasonable limit if this large size is worked around by not including the go.sum file—the go command will use the checksum database (sum.golang.org) instead. The frontend should certainly be updated to display a better message for 413.
@dmitshur , @bcmills
I want to give a try to fix this. Any suggestion on the message that has to be displayed for 413 status code?
Thanks
@uppalabharath Thanks for offering to help (be sure to look over https://go.dev/doc/contribute if you haven't already)!
I think the message just needs to communicate the reason for the problem. Perhaps something like "Snippet is too large to share."
@dmitshur Thanks for the suggestion. would use this message.
@dmitshur it seems like the same fix is needed in playground.js
in tools/godoc/static
Alert message with the fix
@dmitshur I have made the changes and raised a Gerrit review.
Change https://golang.org/cl/366095 mentions this issue: playground: improve error message on playground UI when server returns 413 while sharing snippet
The playground has recently moved to go.dev/play, and so the fix needs to happen in x/website.
it seems like the same fix is needed in
playground.js
intools/godoc/static
Oh, that was actually due to a bug in x/website. It has recently been fixed in CL 366376, and the _content/js/playground.js
file in x/website is being used now. Please direct the fix there.
@dmitshur sure Thanks.. Would make the change in the latest code.
After Changes:
Change https://golang.org/cl/366714 mentions this issue: playground: improve error message on playground UI when server returns 413 while sharing snippet
What did you do?
Navigate to https://play.golang.org.
Paste in the following Go program:
Share
button.What did you expect to see?
A URL from which the program can be run.
What did you see instead?
A browser dialog box, with the text “Server error; try again.”
There are three problems here: a. There is no obvious reason why this should be an error at all. (The
go.sum
file is a bit large, but not outrageously huge.) b. The error message does not indicate the nature of the problem. c. Trying again does not succeed, so the error message is actively wrong to suggest that I do that.