cmd/go: exclude vendor directories when using `go work use -r .`

hyangah commented 2 years ago

What version of Go are you using (`go version`)?

$ go version
go version go1.18 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/hakim/Library/Caches/go-build"
GOENV="/Users/hakim/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/hakim/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/hakim/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/hakim/projects/delve/go.mod"
GOWORK="/Users/hakim/projects/delve/go.work"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bw/6r6k9d113sv1_vvzk_1kfxbm001py5/T/go-build2599549157=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Checked out any project with vendor directory. (I used github.com/go-delve/delve)
Ran go work init; go work use -r . from the root of the directory

What did you expect to see?

go.work file without modules from vendor directories.

What did you see instead?

$ cat go.work
go 1.18

use (
    .
    ./vendor/github.com/cilium/ebpf
    ./vendor/github.com/cosiner/argv
    ./vendor/github.com/creack/pty
    ./vendor/github.com/google/go-dap
    ./vendor/github.com/konsorten/go-windows-terminal-sequences
    ./vendor/github.com/peterh/liner
    ./vendor/github.com/russross/blackfriday/v2
    ./vendor/github.com/shurcooL/sanitized_anchor_name
    ./vendor/github.com/sirupsen/logrus
    ./vendor/github.com/spf13/cobra
    ./vendor/github.com/spf13/pflag
    ./vendor/golang.org/x/xerrors
    ./vendor/gopkg.in/yaml.v2
)

cc @matloob

heschi commented 2 years ago

cc @bcmills @matloob

bcmills commented 2 years ago

🤦‍♂️

This isn't an issue for vendor directories created after CL 315410, but of course there are lots of existing vendor directories created before that.

gopherbot commented 2 years ago

Change https://go.dev/cl/393814 mentions this issue: cmd/go: exclude vendor directories when usinggo work use -r .``

golang / go