search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.86k stars 17.65k forks source link

x/vuln/vulncheck: DeleteSyntheticNodes for all callgraphs? #53206

Closed zpavlinovic closed 2 years ago

zpavlinovic commented 2 years ago

Currently, wrapper for only the final callgraph in vulncheck are inlined via callgraph.DeleteSyntheticNodes. Should the same be done for intermediate ones as well?

zpavlinovic commented 2 years ago

The intermediate calls to DeleteSyntheticNodes do not bring any benefit. In fact, they slow things down for initial cha call graph. The last call for deleting synthetic nodes should stay as it is cheap and simplifies resulting vulnerability graphs.