search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.74k stars 17.63k forks source link

x/text: needs maintainer #54481

Open golightlyb opened 2 years ago

golightlyb commented 2 years ago

@mpvl is listed as as owner of x/text, and appears to have been the main author, but doesn't appear to have worked on anything related to Go on GitHub or Gerrit for over a year. I am a big fan of mpvl's work in x/text but it's half finished and I don't know if any hand off was successful.

There are many Go programmers with an interest in localisation. Could an experienced maintainer coordinate a working group perhaps?

See also #12750.

seankhliao commented 2 years ago

Or we can deprecate it like x/crypto/openpgp

ianlancetaylor commented 2 years ago

This is in the proposal track but I'm not sure it's really a proposal. I agree that it would be nice if x/text had an active maintainer, but the proposal review committee can't cause that to somehow happen.

There are many Go programmers with an interest in localisation. Could an experienced maintainer coordinate a working group perhaps?

That seems a potentially more profitable avenue to pursue, but again isn't really in the purview of the proposal committee.

golightlyb commented 2 years ago

Thank you - I didn't know to what extent this was the case. I've edited to make this a regular issue instead. Please remove from the milestone.

fgm commented 2 years ago

I discussed that at Gophercon EU with @thanm, as I am actually interested in working on this for our own needs. However, for now, I still haven't managed to untangle how to build updates.

thanm commented 2 years ago

@fgm good to hear that you are interested. For building updates, I think there is a CL https://go-review.git.corp.google.com/c/text/+/304029 that needs to move forward. I'll talk with folks about that.

thanm commented 2 years ago

OK, https://go-review.git.corp.google.com/c/text/+/304029 is now submitted. @fgm I think you should be able to build updates now (if not let me know and I can try to help).

golightlyb commented 2 years ago

Really glad there's movement on this.

When it comes to CLs in x/text, is there a reviewer with +2 approval powers we can cc for attention? (I understand we need at least two +1s from Google staff?)

thanm commented 2 years ago

@golightlyb you can CC me on reviews for the time being, I can pull in other folks from the team where needed.

@fgm, are you unblocked at this point?

fgm commented 2 years ago

Hi Than, I'm finishing a project tomorrow so i've been a bit over my head these last weeks. I'll have time to look into this starting next monday

On Tue, 6 Sept 2022 at 17:30, Than McIntosh @.***> wrote:

@golightlyb https://github.com/golightlyb you can CC me on reviews for the time being, I can pull in other folks from the team where needed.

@fgm https://github.com/fgm, are you unblocked at this point?

— Reply to this email directly, view it on GitHub https://github.com/golang/go/issues/54481#issuecomment-1238311118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABC7TZN3SKIB6FLGYE22Y3V45PP7ANCNFSM56WWBR2Q . You are receiving this because you were mentioned.Message ID: @.***>

--

This email, including any attachments, is confidential and may be privileged. If you are not the intended recipient please notify the sender immediately, and please delete it; you should not copy it or use it for any purpose or disclose its contents to any other person. If the email, including any attachments, is legally privileged, you should not forward it to any other person.

thanm commented 2 years ago

Thanks, no hurry, just wanted to check in.

rsc commented 2 years ago

Taking out of proposal process. It's not really a language or library change proposal. @mpvl agrees that having a new maintainer would be good, but that person is signing up for a lot of subtle algorithms. :-)

fgm commented 2 years ago

Update: been working on the various RFCs and associated tools.