search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.52k stars 17.6k forks source link

x/pkgsite: update subrepo list #56482

Closed seankhliao closed 1 year ago

seankhliao commented 1 year ago

What is the URL of the page with the issue?

https://pkg.go.dev/golang.org/x

Currently the sub repo page lists the following repos

benchmarks — benchmarks to measure Go as it is developed. blog — blog.golang.org's implementation. build — build.golang.org's implementation. crypto — additional cryptography packages. debug — an experimental debugger for Go. image — additional imaging packages. mobile — experimental support for Go on mobile platforms. net — additional networking packages. perf — packages and tools for performance measurement, storage, and analysis. pkgsite — home of the pkg.go.dev website. review — a tool for working with Gerrit code reviews. sync — additional concurrency primitives. sys — packages for making system calls. text — packages for working with text. time — additional time packages. tools — godoc, goimports, gorename, and other tools. tour — tour.golang.org's implementation. exp — experimental and deprecated packages (handle with care; may change without warning).

"blog" should be removed, the repo has been cleared out "mod", "oauth2", "term", and "vuln" seem to be suitable candidates for adding to the list "exp" could be moved up to follow alphabetical order?

Could a link to this page be added to the footer under Packages / Standard library?

findleyr commented 1 year ago

Suggested changes make sense to me. Not sure whether oauth2 and term were intentionally omitted, since they have existed for some time. mod and vuln are new enough that I suspect they just post-dated the original list.

CC @jamalc, who appears to have some context on this page.

jamalc commented 1 year ago

We should make this page more accessible, a link could fit nicely in the new navbar and the footer. I believe we copied the list from godoc for #47281. #37265 mentions that the list was intentionally not exhaustive but I'm not sure what is the threshold for noteworthy.

AGWA commented 1 year ago

If the list is intentionally not exhaustive, I would suggest noting this on the page. I ended up reinventing the wheel on some modules-related stuff because I didn't know that golang.org/x/mod existed; I would have looked harder if I knew the list wasn't exhaustive.

gopherbot commented 1 year ago

Change https://go.dev/cl/476202 mentions this issue: static/frontend/subrepo: update subrepo list

findleyr commented 1 year ago

It took me a while to get to this, sorry.

I've made most of the recommended changes here. I also included x/website in the list.

@jamalc you mentioned making this page more accessible. It seemed OK to me, though I didn't try it out with a screen reader. Can we close this issue and handle accessibility more holistically in a separate issue? (I think we have plans to do a more widespread accessibility analysis)

jamalc commented 1 year ago

Yes, I meant "easy to be reached" and we will address web accessibility more holistically later this year.

findleyr commented 1 year ago

"easy to be reached"

Oh. That makes sense now that I re-read your comment!

Ok, then I'll close this now.