x/crypto/acme: test failures due to hard-coded timeouts

[gopherbot]

#!watchflakes
post <- pkg == "golang.org/x/crypto/acme" && `took too long|context deadline exceeded`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRFC_CreateOrderCert (3.79s)
    rfc8555_test.go:981: CreateOrderCert: context deadline exceeded

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/crypto/acme" && test == "TestRFC_CreateOrderCert"

2022-11-17 19:18 darwin-amd64-11_0 crypto@2c476679 go@e727f419 x/crypto/acme.TestRFC_CreateOrderCert (log)

--- FAIL: TestRFC_CreateOrderCert (3.79s) rfc8555_test.go:981: CreateOrderCert: context deadline exceeded

— watchflakes

[bcmills]

This appears to be caused by a hard-coded timeout in the test. In general, tests should avoid making assumptions about the speed or load factor of the machine on which they are running.

[bcmills]

(attn @rolandshoemaker @golang/security; CC @FiloSottile)

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/crypto/acme" && `took too long|context deadline exceeded`

2022-12-06 15:29 darwin-amd64-11_0 crypto@eb2c4062 go@dc04f3ba x/crypto/acme.TestRFC_WaitOrderError (log)

--- FAIL: TestRFC_WaitOrderError (3.00s) rfc8555_test.go:921: WaitOrder took too long to return

— watchflakes

[gopherbot]

Change https://go.dev/cl/456123 mentions this issue: acme: eliminate arbitrary timeouts in tests