search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.04k stars 17.67k forks source link

x/build/devapp/owners: document responsibilities of primary and secondary code owners #57532

Open hickford opened 1 year ago

hickford commented 1 year ago

Go Code Owners page https://dev.golang.org/owners lists primary and secondary code owners by project. The page should explain what this information means -- what are the responsibilities of code owners? https://go.dev/doc/contribute doesn't mention code owners at all.

It should also explain the difference between primary and secondary owners. It looks like Gerrit https://go-review.googlesource.com/ automatically adds primaries as reviewers. Are there any other differences?

dmitshur commented 1 year ago

CC @golang/release.

hickford commented 1 year ago

@dmitshur @golang/release @golang/proposal-review Is anyone able to explain the responsibilities of Go code owners and the difference between primaries and secondaries? https://dev.golang.org/owners doesn't explain and https://go.dev/doc/contribute doesn't even mention code owners.

dmitshur commented 1 year ago

I'll note that there are some mentions of owners in https://go.dev/wiki/GerritAccess:

Typically, you should only Code-Review+2 code in directories or packages that you "own"; the exception is trivial and obviously correct changes.

You should only submit changes with a Code-Review+2 from the owner of that area (maybe you!).

And some mentions of "port maintainers", which is similar to code owners but for ports, in https://go.dev/wiki/PortingPolicy.

The distinction between primary and secondary is not at all well defined at this time.