search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.25k stars 17.7k forks source link

x/build: enable snapshotting for misc-compile builders #58310

Open mknyszek opened 1 year ago

mknyszek commented 1 year ago

Right now misc-compile builders don't snapshot at all, forcing a re-run of make.bash. This is especially annoying for subrepos, since it adds a bunch of unnecessary build latency. We should at the very least enable snapshotting per builder name (which makes sense, since we'll have std built for the given GOOS/GOARCH).

mknyszek commented 1 year ago

CC @golang/release

bcmills commented 1 year ago

Since the Go compiler is a cross-compiler on every platform, we could alternately run all of the misc-compile subrepo builders with a common, already-snapshotted host toolchain (such as linux/amd64).

The x/build changes might be more invasive, but the end result would be more resource-efficient.