Closed bcmills closed 1 year ago
I think this is something to do with an expiration — all of the builders started failing at once, even on TryBots at older base CLs (https://storage.googleapis.com/go-build-log/cd3d6904/windows-386-2016_967987aa.log).
Change https://go.dev/cl/472295 mentions this issue: crypto/x509: fix system root tests + darwin intermediate handling
Change https://go.dev/cl/472097 mentions this issue: crypto/x509: avoid nil dereference in tests
Found new dashboard test flakes for:
#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
@gopherbot Please backport at minimum the Windows text fix aspect of this issue.
This is needed to fix failing tests on release branches.
Backport issue(s) opened: #58810 (for 1.19), #58811 (for 1.20).
Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.
Change https://go.dev/cl/472496 mentions this issue: crypto/x509: fix broken tests
Change https://go.dev/cl/472615 mentions this issue: [release-branch.go1.19] crypto/x509: fix system root tests + darwin intermediate handling
Change https://go.dev/cl/472616 mentions this issue: [release-branch.go1.20] crypto/x509: fix system root tests + darwin intermediate handling
Change https://go.dev/cl/472618 mentions this issue: [release-branch.go1.20] crypto/x509: fix broken tests
Change https://go.dev/cl/472617 mentions this issue: [release-branch.go1.19] crypto/x509: fix broken tests
Found new dashboard test flakes for:
#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
Thanks watchflakes, but commit 600d37 is before the fix in commit 21e451e.
Found new dashboard test flakes for:
#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
Found new dashboard test flakes for:
#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
Found new dashboard test flakes for:
#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
These all appear old.
https://build.golang.org/log/97b5cac923dc9079392efd9637b9fffa8b9f7592:
(attn @golang/security @dmitshur)