Open pjweinb opened 1 year ago
Here is a CL with failing tests: https://go.dev/cl/589939
Additional tests to fix this support of x/telemetry
on OpenBSD.
Clone x/telemetry
sources from https://go.googlesource.com/telemetry
OK Build telemetry
on OpenBSD/amd64 (current version) with Go 1.23.1 (package/port go
installed for OpenBSD/amd64)
Patch internal/telemetry/dir.go
to enable OpenBSD platform:
--- /tmp/dir.go.orig Thu Sep 26 15:21:22 2024
+++ /tmp/dir.go Thu Sep 26 15:21:09 2024
@@ -152,7 +152,7 @@
// TODO(rfindley): move to a more appropriate file.
const DisabledOnPlatform = false ||
// The following platforms could potentially be supported in the future:
runtime.GOOS == "openbsd" || // #60614
// runtime.GOOS == "openbsd" || // #60614 runtime.GOOS == "solaris" || // #60968 #60970 runtime.GOOS == "android" || // #60967 runtime.GOOS == "illumos" || // #65544
Tests failure in internal/counter
$ cd internal/counter
$ go test | grep FAIL
--- FAIL: TestBasic (0.00s)
--- FAIL: TestMissingLocalDir (0.02s)
--- FAIL: TestParallel (0.01s)
--- FAIL: TestLarge (0.07s)
--- FAIL: TestStack (0.00s)
--- FAIL: TestRotateCounters (0.02s)
FAIL
FAIL golang.org/x/telemetry/internal/counter 2.849s
Full log tests failure in internal/counter
with go test
: telemetry-test.log
After some analysis/debug, it seems than there is an issue with:
Parse
function in internal/counter/parse.go
ReadStack
function in internal/counter/stackcounter.go
This is a placeholder to note that in the telemetry package, two tests are skipped if runtime.GOOS is openbsd.