golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.02k stars 17.54k forks source link

x/build: Tricium should not enforce Go style rules on testdata/*.go #61214

Open adonovan opened 1 year ago

adonovan commented 1 year ago

The new Tricium CI system keeps pointing out that *.go files don't have a copyright header, even when they are in a testdata directory. Test data files sometimes need to be subtly invalid Go for a wide variety of reasons, and the CI system shouldn't try to make them look like production code.

erifan commented 1 year ago

Also include automatically generated files.

bcmills commented 1 year ago

I think @rsc suggested that we disable the Tricium check entirely. Its spell-checker has a number of idiosyncrasies specific to Chromium that don't really apply to Go.

gopherbot commented 1 year ago

Change https://go.dev/cl/508865 mentions this issue: recipes/recipes: disable tricium copyright check

cagedmantis commented 1 year ago

The copyright check has been temporarily disabled.