search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.79k stars 17.64k forks source link

x/build/cmd/relui: VERSION file CL submission race affecting RCs after early thaw #61713

Open dmitshur opened 1 year ago

dmitshur commented 1 year ago

RC releases that happen after early thaw have a race: the relui workflow reads the head of the release branch at the start and does its work. During early thaw, the latest release branch is open to all approvers, and if any CL is submitted before the VERSION CL is, they'd need to be temporarily reverted and resent, or the relui workflow would need to be started anew.

So we need to temporarily freeze the release branch during such RC releases. This is the tracking issue for that.

CC @golang/release.

heschi commented 1 year ago

I think it might be fine, and certainly easier, to do the VERSION CL submission at the beginning of the workflow for RCs. For more sensitive releases we don't want to do externally-visible stuff until the release is ready to ship, but RCs are lower stakes.

dmitshur commented 1 year ago

That might be fine. It brings about some inflexibility and complexity overhead, too, which I imagine you're taking into account.