search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.82k stars 17.65k forks source link

x/build: build broken on windows/386 since CL 504531 #63243

Closed bcmills closed 1 year ago

bcmills commented 1 year ago

What did you do?

~/x/build$ GOOS=windows GOARCH=386 go test -c -o /dev/null ./...

What did you expect to see?

All tests build successfully.

What did you see instead?

~/x/build$ GOOS=windows GOARCH=386 go test -c -o /dev/null ./...
go: downloading github.com/tarm/serial v0.0.0-20180830185346-98f6abe2eb07
# github.com/apache/arrow/go/v11/internal/utils
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:76:4: undefined: TransposeInt8Int8
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:78:4: undefined: TransposeInt8Int16
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:80:4: undefined: TransposeInt8Int32
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:82:4: undefined: TransposeInt8Int64
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:84:4: undefined: TransposeInt8Uint8
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:86:4: undefined: TransposeInt8Uint16
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:88:4: undefined: TransposeInt8Uint32
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:90:4: undefined: TransposeInt8Uint64
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:95:4: undefined: TransposeInt16Int8
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:97:4: undefined: TransposeInt16Int16
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:97:4: too many errors
…
FAIL    golang.org/x/build/cmd/buildstats [build failed]
…
FAIL    golang.org/x/build/internal/buildstats [build failed]

This build break appears to have been introduced in https://go.dev/cl/504531 (attn @cagedmantis @heschi @dmitshur), but was masked on the build dashboard by a combination of a missing builder for this platform on the development branch (#63240) and a lack of watchflakes reporting for persistently-broken builds (#58819).

heschi commented 1 year ago

It's not great that this happened by accident. But FWIW I think x/build doesn't need to support all first class ports, since it's internal infrastructure, and I'm fine leaving it broken.

heschi commented 1 year ago

We discussed and are fine leaving it broken. Thanks for pointing it out so we could make an actual decision.