search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
122.7k stars 17.49k forks source link

x/tools/gopls: bug in analysis importer reported by telemetry #64236

Open adonovan opened 9 months ago

adonovan commented 9 months ago

This stack sbGdaw, hz09pg, zhKNnQ was reported by telemetry:

cache.(*analysisNode)._import.func1:41 is

        pkg, err := gcimporter.IImportShallow(an.fset, getPackages, an.summary.Export, string(an.m.PkgPath), bug.Reportf)
        if err != nil {
            an.typesErr = bug.Errorf("%s: invalid export data: %v", an.m, err)
            an.types = nil
        } else if pkg != an.types {
            log.Fatalf("%s: inconsistent packages", an.m)
        }
gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?391
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:32
go/types.(*Checker).Files:?341
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117
golang.org/x/tools/gopls@v0.14.1 go1.21.3 linux/amd64 (1)

Reported using golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: NpfwWw OeW1wA

Duplicates:

This stack WRBqTw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:10
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?383
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:18
go/types.(*Checker).Files:?307
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117
golang.org/x/tools/gopls@v0.14.2 go1.19.13 darwin/arm64 (1)

This stack C7ZvyQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:29
go/types.(*Checker).Files:?372
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117
golang.org/x/tools/gopls@v0.14.2 go1.22rc2 darwin/arm64 other,vscode (1)

This stack 6jGwIA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:35
golang.org/x/tools/gopls/internal/util/bug.Errorf:2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:29
go/types.(*Checker).Files:?372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:118
golang.org/x/tools/gopls@v0.15.0-pre.2 go1.22rc2 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: OeW1wA NpfwWw sNopDQ YUgxTQ g_3FdA qOlVPg sNopAA NpfwVg rcxYqw qOlVMw rcxYpg MCkoAw

findleyr commented 7 months ago

We can live with this in v0.15.0. Let's move to v0.16.0

adonovan commented 6 months ago

This stack NpfwWw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118
golang.org/x/tools/gopls@v0.15.0-pre.3 go1.22.0 darwin/arm64 vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 6 months ago

This stack OeW1wA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:36
go/types.(*Checker).Files:?355
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117
golang.org/x/tools/gopls@v0.14.2 devel darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 6 months ago

This stack sNopDQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118
golang.org/x/tools/gopls@v0.15.1 go1.21.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 5 months ago

This stack YUgxTQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1.1.1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.15.1 go1.22.0 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 5 months ago

This stack g_3FdA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=373
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118
golang.org/x/tools/gopls@v0.15.1 devel darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 5 months ago

This stack qOlVPg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=304
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118
golang.org/x/tools/gopls@v0.15.2 go1.20.6 windows/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 4 months ago

This stack sNopAA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+115
golang.org/x/tools/gopls@v0.15.3 go1.21.2 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.15.3-pre.2 go1.21.2 linux/amd64 vscode (3)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 4 months ago

This stack NpfwVg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+115
golang.org/x/tools/gopls@v0.15.3 go1.22.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 4 months ago

This stack rcxYqw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+10
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=383
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=307
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118
golang.org/x/tools/gopls@v0.15.2 go1.19.13 darwin/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 4 months ago

This stack qOlVMw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=304
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+115
golang.org/x/tools/gopls@v0.15.3 go1.20.13 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 3 months ago

This stack rcxYpg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+10
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=383
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=307
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+115
golang.org/x/tools/gopls@v0.15.3 go1.19.6 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan commented 3 weeks ago

This stack MCkoAw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=67
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+31
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+26
go/types.(*Checker).Files:+13
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+115
golang.org/x/tools/gopls@v0.16.1 go1.23rc2 linux/amd64 vscode-insiders (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.