x/text/encoding/charmap: maketable.go fails because of old URLs

[zacharysyoung]

Go version

go version go1.21.4 darwin/arm64

What operating system and processor architecture are you using (go env)?

GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/zyoung/Library/Caches/go-build'
GOENV='/Users/zyoung/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/zyoung/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/zyoung/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/mn/wtsctdj937xczgzgf858yjb80000gn/T/go-build2238334321=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

Ran go run maketables.go from text/encoding/charmap directory.

What did you expect to see?

Nothing (successful run).

What did you see instead?

2023/12/01 10:22:45 "http://source.icu-project.org/repos/icu/data/trunk/charset/data/ucm/glibc-IBM037-2.1.2.ucm": only 0 characters found (wrong page format?)
exit status 1

The UCM spec files have moved from source.icu-project.org to github.com.

[gopherbot]

Change https://go.dev/cl/546576 mentions this issue: encoding/charmap: update UCM spec file URL prefix

[dmitshur]

Thanks for reporting and sending a fix. CC @mpvl.