search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.36k stars 17.58k forks source link

x/pkgsite: Deprecation annotation for packages isn't displayed #66574

Open johannes-riecken opened 6 months ago

johannes-riecken commented 6 months ago

What is the URL of the page with the issue?

https://pkg.go.dev/google.golang.org/api@v0.171.0/sql/v1beta4

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:99.0) Gecko/20100101 Firefox/99.0

What did you do?

I opened the page above.

What did you expect to see?

A prominent deprecation warning next to the package description. I expect this, because the package comment for the source file starts with "// Deprecated: ".

What did you see instead?

No mention of the package being deprecated.

jfrech commented 6 months ago

No mention of the package being deprecated.

My browser renders the deprecation paragraph at the very end of the "Overview" section, behaving analogous to e. g. https://pkg.go.dev/io/ioutil.

johannes-riecken commented 6 months ago

No mention of the package being deprecated.

My browser renders the deprecation paragraph at the very end of the "Overview" section, behaving analogous to e. g. https://pkg.go.dev/io/ioutil.

Oh, my bad, I must have missed that. I'd prefer having it more visually prominent though, as it's easy to miss.

jfrech commented 6 months ago

I would agree: a beige background -- as is done with deprecated functions -- around the "Deprecated:" paragraph I would welcome.