Closed qiulaidongfeng closed 1 week ago
This PR (HEAD: 8f1dae65fc11a5b71ff0bc73acb7e369b50dd4bd) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581956.
Important tips:
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from qiulaidongfeng:
Patch Set 2: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-04-29T10:42:11Z","revision":"4a00f27b612dee10d46f665c5b9ca1b7fe5810ea"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from qiulaidongfeng:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-04-29T18:15:55Z","revision":"4a00f27b612dee10d46f665c5b9ca1b7fe5810ea"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from David Chase:
Patch Set 2: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 499476cc4acdf58ecf0fec9f7281bfb90edc7c82) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581956.
Important tips:
Message from qiulaidongfeng:
Patch Set 3: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-04T00:52:52Z","revision":"7e63da9ca3b159f41c2bb2b9038edf5b465a2998"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from qiulaidongfeng:
Patch Set 3: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results):
FAILURE
Tests failed. See all test results.
Error: shard 1: failed to run "go tool dist test -json": exit status 1
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from qiulaidongfeng:
Patch Set 3: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 3: Auto-Submit+1 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-04T01:07:59Z","revision":"7e63da9ca3b159f41c2bb2b9038edf5b465a2998"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. After addressing review feedback, remember to publish your drafts!
This PR is being closed because golang.org/cl/581956 has been merged.
Follow-up CL help package like unique use Clone.