golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.96k stars 17.66k forks source link

x/website: tables are awkwardly formatted #67368

Open jjlin opened 5 months ago

jjlin commented 5 months ago

What is the URL of the page with the issue?

https://go.dev/ref/mod#environment-variables

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36

Screenshot

image

What did you do?

Visit https://go.dev/ref/mod#environment-variables

What did you see happen?

The table of environment variables has no cell borders and the content is vertically centered. This makes it needlessly difficult to understand which variable corresponds to which description, and where one description ends and the next begins.

What did you expect to see?

If the table is going to have no borders, then I think the content should be top-aligned.

I'd expect that other tables in the Go documentation probably have this issue as well.

hyangah commented 5 months ago

I agree this table will look better and more readable if it's top-aligned. CSS adjustment for this table is welcome.

gopherbot commented 4 months ago

Change https://go.dev/cl/592955 mentions this issue: _content: add styles for mod table

kevinpeno commented 3 weeks ago

Not sure where to throw it, but the following worked well for that page, imo. The padding isn't necessary, but I thought it helped readability a little bit. I didn't see .ModTable defined anywhere in styles.css, so there shouldn't be any conflicts.

.ModTable th, .ModTable td {
    vertical-align: baseline;
    text-align: left;
    padding: 1rem;
}

Screenshot 2024-10-13 200255 Screenshot 2024-10-13 200238 Screenshot 2024-10-13 200218