search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
120.66k stars 17.33k forks source link

x/tools/gopls/internal/test/marker: Test/diagnostics/analyzers.txt failing #67429

Closed adonovan closed 4 weeks ago

adonovan commented 4 weeks ago

Starting with https://go.dev/cl/580836, the linux-amd64-nocgo builder is consistently failing:

--- FAIL: Test (0.48s)
    --- FAIL: Test/diagnostics/analyzers.txt (5.90s)
        marker_test.go:1584: cgocall.go:10:29 (diagnostics/analyzers.txt:68:29): no diagnostic at cgocall.go:10:6-12 (diagnostics/analyzers.txt:68:6-12) matches "passing Go type with embedded pointer to C"
        marker_test.go:220: cgocall.go:1:9 (diagnostics/analyzers.txt:59:9): unexpected diagnostic: "No packages found for open file /workdir/tmp/Testdiagnosticsanalyzers.txt3424688837/001/work/cgocall.go.\nThis file is ignored by your gopls build."
FAIL
FAIL    golang.org/x/tools/gopls/internal/test/marker   14.776s
gopherbot commented 4 weeks ago

Change https://go.dev/cl/586096 mentions this issue: gopls/internal/test/marker: fix analyzers.txt test that requires cgo