Closed aimuz closed 3 weeks ago
This PR (HEAD: d98365c0444c0467d8b4213674f6cf166906e900) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586239.
Important tips:
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Zhen Li:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from qiu laidongfeng2:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-17T06:28:07Z","revision":"1cec43a30ce62060f451126681c9726ac64b17a2"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from qiu laidongfeng2:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has failed the run. Reason:
Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):
FAILURE
Error:
failed to run "test golang.org/x/tools module": exit status 1
failed to run "test golang.org/x/tools/gopls module": exit status 1
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-18T15:08:43Z","revision":"52a946c1762b08c5132fd4c56a98916024753261"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. After addressing review feedback, remember to publish your drafts!
This PR is being closed because golang.org/cl/586239 has been merged.
Refactor compare function to use cmp.Compare for various types. Remove redundant floatCompare and isNaN functions.