search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.25k stars 17.57k forks source link

x/net/http2: TestServerWritesTrailers_WithoutFlush failures #67693

Open gopherbot opened 4 months ago

gopherbot commented 4 months ago 
#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Transfer-Encoding"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Trailer"
    server_test.go:641: Error while expecting a HEADERS frame: i/o timeout
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 4 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-05-28 22:41 x_net-go1.22-js-wasm net@03c24c2d release-branch.go1.22@cb55d1a0 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Range" http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Trailer" server_test.go:641: Error while expecting a HEADERS frame: i/o timeout --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)
2024-05-28 22:41 x_net-gotip-js-wasm net@03c24c2d go@c26be72d x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Range" http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Trailer" server_test.go:641: Error while expecting a HEADERS frame: i/o timeout --- FAIL: TestServerWritesTrailers_WithoutFlush (0.01s)
2024-05-28 22:41 x_net-go1.22-js-wasm net@9f5b79b0 release-branch.go1.22@cb55d1a0 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Range" http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Trailer" server_test.go:641: Error while expecting a HEADERS frame: i/o timeout --- FAIL: TestServerWritesTrailers_WithoutFlush (0.01s)
2024-05-28 22:41 x_net-gotip-js-wasm net@9f5b79b0 go@c26be72d x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Range" http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Transfer-Encoding" server_test.go:641: Error while expecting a HEADERS frame: i/o timeout http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Trailer" --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

neild commented 4 months ago

I can consistently reproduce this as c26be72d, but not at HEAD, so I believe https://go.dev/cl/586249 already fixed this.

gopherbot commented 4 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-05-30 19:26 x_net-go1.22-js-wasm net@56082791 release-branch.go1.22@74565750 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Range" http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Trailer" server_test.go:2789: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 4 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-06-03 16:01 x_net-gotip-js-wasm net@603e3e63 go@eaa7d9ff x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Range" http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 3 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-06-12 20:39 x_net-gotip-js-wasm net@9617c633 go@82c14346 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/07/03 22:52:27 ignoring invalid trailer "Range" http2_test.go:66: 2024/07/03 22:52:27 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/07/03 22:52:27 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/07/03 22:52:27 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 3 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-07-05 10:47 x_net-go1.23-js-wasm net@77708f71 release-branch.go1.23@7dff7439 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/07/05 10:53:00 ignoring invalid trailer "Range" http2_test.go:66: 2024/07/05 10:53:00 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/07/05 10:53:00 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/07/05 10:53:00 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 2 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-07-16 16:05 x_net-go1.23-js-wasm net@032e4e43 release-branch.go1.23@30b6fd60 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/07/16 16:06:06 ignoring invalid trailer "Range" http2_test.go:66: 2024/07/16 16:06:06 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/07/16 16:06:06 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/07/16 16:06:06 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

dmitshur commented 1 month ago

From looking at the watchflakes reports above and x-net-gotip, x-net-go1.23, x-net-go1.22 post-submit dashboards, this still seems to happen after golang/net@0d515a53 (CL 586249), and only on the js/wasm port.

CC @golang/js.

gopherbot commented 4 weeks ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-09-04 22:19 x_net-go1.23-js-wasm net@9bf379fa release-branch.go1.23@69234ded x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/09/05 15:28:00 ignoring invalid trailer "Range" http2_test.go:66: 2024/09/05 15:28:00 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/09/05 15:28:00 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/09/05 15:28:00 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 3 weeks ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-09-05 16:43 x_net-go1.22-js-wasm net@35b4abae release-branch.go1.22@6fab4b9a x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/09/06 14:40:37 ignoring invalid trailer "Range" http2_test.go:66: 2024/09/06 14:40:37 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/09/06 14:40:37 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/09/06 14:40:37 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)
2024-09-05 16:43 x_net-gotip-js-wasm net@35b4abae go@557211c1 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/09/06 17:39:11 ignoring invalid trailer "Range" http2_test.go:66: 2024/09/06 17:39:11 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/09/06 17:39:11 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/09/06 17:39:11 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 2 weeks ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-09-05 16:43 x_net-go1.23-js-wasm net@35b4abae release-branch.go1.23@e6598e7b x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/09/06 16:16:46 ignoring invalid trailer "Range" http2_test.go:66: 2024/09/06 16:16:46 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/09/06 16:16:46 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/09/06 16:16:46 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 6 days ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-09-06 18:26 x_net-go1.22-js-wasm net@3c333c0c release-branch.go1.22@b4086b7c x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/09/11 22:22:16 ignoring invalid trailer "Range" http2_test.go:66: 2024/09/11 22:22:16 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/09/11 22:22:16 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/09/11 22:22:16 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)
2024-09-25 18:00 x_net-gotip-js-wasm net@4790dc70 go@49e542aa x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/09/25 18:01:27 ignoring invalid trailer "Range" http2_test.go:66: 2024/09/25 18:01:27 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/09/25 18:01:27 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/09/25 18:01:27 ignoring invalid trailer "Trailer" server_test.go:2794: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes

gopherbot commented 1 day ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-09-25 18:02 x_net-go1.23-js-wasm net@7191757b release-branch.go1.23@fbddfae6 x/net/http2.TestServerWritesTrailers_WithoutFlush (log) === RUN TestServerWritesTrailers_WithoutFlush http2_test.go:66: 2024/09/25 18:03:39 ignoring invalid trailer "Range" http2_test.go:66: 2024/09/25 18:03:39 ignoring invalid trailer "Transfer-Encoding" http2_test.go:66: 2024/09/25 18:03:39 ignoring invalid trailer "Content-Length" http2_test.go:66: 2024/09/25 18:03:39 ignoring invalid trailer "Trailer" server_test.go:2796: got no frame, want frame *http2.HeadersFrame --- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

— watchflakes