golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
121.14k stars 17.36k forks source link

x/tools/gopls: enable telemetry prompting for all editors #67821

Open hyangah opened 1 month ago

hyangah commented 1 month ago

Gopls's telemetry prompting is currently disabled by default. Client should enable by either setting an internal setting or by calling the prompt command. VS Code Go extension calls the command for the user selected based on the hash of vscode client id, after at least a week has passed since a telemetry-enabled gopls version runs. We now want to move this sampling and decision making to gopls, too, and enable the prompting in all editors, not only in vscode.

That means we need to record more info in the prompt file in the gopls config directory.

Requirement:

Some nice-to-haves:

gopherbot commented 1 month ago

Change https://go.dev/cl/589517 mentions this issue: gopls/internal/server: conditionally prompt for telemetry

gopherbot commented 1 month ago

Change https://go.dev/cl/589836 mentions this issue: internal/settings: prompt for telemetry by default

gopherbot commented 1 week ago

Change https://go.dev/cl/595535 mentions this issue: extension/src/goTelemetry: set telemetry env vars