Open adonovan opened 2 months ago
@adonovan can I take this issue up?
@adonovan can I take this issue up?
Thanks for offering. The code change should be trivial---just a deletion. But before we can do it we need to ascertain whether it is safe for existing clients. I know it is safe for Emacs+eglot, and I suspect it is safe for Vim+coc.nvim, which uses very little Go-specific client-side logic. That leaves primarily vscode-go; if @hyangah says it is safe, then let's remove it.
/assign
I have raised the PR https://github.com/golang/tools/pull/501. Yeah, sure we can wait for @hyangah to revert on this issue.
It's safe to delete.
gopls has two commands (Test and RunTests) that are identical in behavior. Their only difference is the form of the parameters: three for Tests, versus a single struct of three fields for RunTest. Test is described as "legacy". We should delete it.