search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
122.19k stars 17.46k forks source link

x/tools/gopls: delete command.Test #67920

Open adonovan opened 2 months ago

adonovan commented 2 months ago

gopls has two commands (Test and RunTests) that are identical in behavior. Their only difference is the form of the parameters: three for Tests, versus a single struct of three fields for RunTest. Test is described as "legacy". We should delete it.

nikzayn commented 2 months ago

@adonovan can I take this issue up?

adonovan commented 2 months ago

@adonovan can I take this issue up?

Thanks for offering. The code change should be trivial---just a deletion. But before we can do it we need to ascertain whether it is safe for existing clients. I know it is safe for Emacs+eglot, and I suspect it is safe for Vim+coc.nvim, which uses very little Go-specific client-side logic. That leaves primarily vscode-go; if @hyangah says it is safe, then let's remove it.

nikzayn commented 2 months ago

/assign

I have raised the PR https://github.com/golang/tools/pull/501. Yeah, sure we can wait for @hyangah to revert on this issue.

hyangah commented 2 months ago

It's safe to delete.