x/tools/gopls: don't offer code lenses/actions that assume go build when using GOPACKAGESDRIVER

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

122.85k stars 17.52k forks source link

Open adonovan opened 3 months ago

adonovan commented 3 months ago

Gopls should not offer any commands that assume the underlying build command is go when using a go packages driver (e.g. bazel). See https://github.com/golang/go/issues/67615#issuecomment-2158863721 for the various commands that need tweaking.

gabyhelp commented 3 months ago

Similar Issues

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

adonovan commented 3 months ago

Opinion: the ML-based "similar issues" are not entirely dissimilar: in particular, the first seems like an umbrella issue that covers this one.

findleyr commented 3 months ago

Indeed, they're not as dissimilar as I first thought.