x/pkgsite: links in summaries have opacity zero

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

121.36k stars 17.38k forks source link

x/pkgsite: links in summaries have opacity zero #68132

Open favonia opened 3 weeks ago

favonia commented 3 weeks ago

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/favonia/cloudflare-ddns#readme-migration-guides

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0

Screenshot

What did you do?

Navigate down to the section.

What did you see happen?

Links in <summary> are not visible (opacity: 0 in terms of CSS).

What did you expect to see?

Links should be visible even within <summary>.

jimmyfrasche commented 3 weeks ago

Bug aside, I would not recommend, in general, putting clickable things in clickable things as it causes accessibility issues. I would recommend removing the links from the summary button, even if this gets fixed.

favonia commented 3 weeks ago

@jimmyfrasche You are right. Working on it.

gopherbot commented 3 weeks ago

Change https://go.dev/cl/595055 mentions this issue: static/frontend: always show links in readme files

ansaba commented 3 weeks ago

cc: @jba

findleyr commented 1 week ago

Did some digging:

The opacity:0 was added in https://go.dev/cl/304649, presumably to make the anchor links hidden. I do not now why the summary selector was included in that change.

Then the opacity:0 style for anchor links was rendered obsolete by https://go.dev/cl/520255.

So the fix LGTM.