Closed lmorg closed 1 day ago
@griesemer this recent panic appears to occur in logic that was recently back-ported to 1.22: https://go.dev/cl/580937.
The assertion failure is here: https://cs.opensource.google/go/go/+/refs/tags/go1.22.5:src/go/types/stmt.go;l=932;drc=11b861e45936eb7911e30304163a14553f53a5d1
assert(i == 0) // at most one iteration variable (rhs[1] == nil for rangeOverInt)
@lmorg if you happen to recall any details about the range statement you were editing at the time of this panic, that would be helpful, but in any case we should be able to find the logical flaw (I'll note that this assertion was discussed in code review; we must have missed something).
@griesemer tentatively assigning to you for further investigation. I can also take a look, but will first be busy with #68311. The bug may be easy to spot--I did not attempt.
Actually, I think I'll be able to get to this sooner than @griesemer.
CC @timothy-king for awareness: Tim, I'll ask you to review! :)
@findleyr I can't say for 100% certain but looking at the commit times on the project I was working on, and corrolating that to the report time of this issue, I'd guess it was this one:
Sorry, this one: https://github.com/lmorg/murex/blob/37b8ce0c539eefce7c6deadb28f9bc2d51a5e39a/builtins/core/modules/cmd-list.go#L95
I cannot replicate the issue though.
edit: Nope. That wasn't it.
~gopls
sets types.Config.Error
to a non-nil function. If check.conf.Error != nil
, then~
case v == nil && sValue != nil:
check.softErrorf(sValue, InvalidIterVar, "range over %s permits only one iteration variable", &x)
~won't stop execution in (*types.Checker).rangeStmt
. This might be how assert(i == 0)
is getting triggered.~
Related Issues and Documentation
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
Change https://go.dev/cl/597356 mentions this issue: go/types: fix range over int invariant
@gopherbot please backport this issue to 1.22. It is a regression in the latest patch release and causes crashes in gopls.
Backport issue(s) opened: #68370 (for 1.22).
Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.
Not technically a release blocker since this is already released in 1.22.5, but we should fix for 1.23 and backport.
Thanks @timothy-king for investigating.
Thanks both. I appreciate there wasn't much to go on for this particular issue (sorry about that)
@lmorg your time to file the issue is greatly appreciated. No need to apologize.
Change https://go.dev/cl/598055 mentions this issue: go/types: fix assertion failure when range over int is not permitted
Change https://go.dev/cl/598055 mentions this issue: [release-branch.go1.22] go/types: fix assertion failure when range over int is not permitted
Closing as I believe this is fixed (in go@master). The backport issue will be closed when 1.22.6 is released.
Thanks @timothy-king for the fix.
gopls version: v0.16.1/go1.22.5 gopls flags: update flags: proxy extension version: 0.41.4 environment: Visual Studio Code darwin initialization error: undefined issue timestamp: Fri, 05 Jul 2024 22:28:48 GMT restart history: Fri, 05 Jul 2024 21:41:59 GMT: activation (enabled: true)
ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.
Describe what you observed.
gopls stats -anon
{ "DirStats": { "Files": 1984, "TestdataFiles": 5, "GoFiles": 1083, "ModFiles": 1, "Dirs": 235 }, "GOARCH": "arm64", "GOOS": "darwin", "GOPACKAGESDRIVER": "", "GOPLSCACHE": "", "GoVersion": "go1.22.5", "GoplsVersion": "v0.16.1", "InitialWorkspaceLoadDuration": "1.169338542s", "MemStats": { "HeapAlloc": 60239376, "HeapInUse": 106414080, "TotalAlloc": 703540872 }, "WorkspaceStats": { "Files": { "Total": 2250, "Largest": 5748466, "Errs": 0 }, "Views": [ { "GoCommandVersion": "go1.22.5", "AllPackages": { "Packages": 742, "LargestPackage": 155, "CompiledGoFiles": 3962, "Modules": 26 }, "WorkspacePackages": { "Packages": 271, "LargestPackage": 63, "CompiledGoFiles": 1417, "Modules": 1 }, "Diagnostics": 0 } ] } }