Open hyangah opened 1 month ago
This proposal has been added to the active column of the proposals project and will now be reviewed at the weekly proposal review meetings. — rsc for the proposal review group
I really like this proposal and if it stays unchanged I think it should still be accepted. Improving the tooling using telemetry is a great idea.
A few improvement suggestions:
I think that pointing out which data points are missing for the Delve team to direct their efforts today will make this proposal a lot more complete
Will these metrics work in Goland as well?
Very likely yes. Goland ships its own precompiled version of delve, so they could disable telemetry completely but I don't think they would.
It sounds like the line being proposed is: "Go telemetry is only intended for use in programs maintained by the Go team and their selected dependencies like Delve."
This seems like a reasonable line. And just like we do for other programs, only counters for a specific enumerated set of released Delve versions would be uploaded. So this seems fine.
Do I have that right?
Based on the discussion above, this proposal seems like a likely accept. — rsc for the proposal review group
The previous line for what programs we are willing to take telemetry from was "Go telemetry is only intended for use in programs maintained by the Go team."
The proposal is to change this to "... programs maintainted by the Go team and their selected dependencies like Delve."
No change in consensus, so accepted. 🎉 This issue now tracks the work of implementing the proposal. — rsc for the proposal review group
The previous line for what programs we are willing to take telemetry from was "Go telemetry is only intended for use in programs maintained by the Go team."
The proposal is to change this to "... programs maintainted by the Go team and their selected dependencies like Delve."
Proposal Details
Delve, the Go debugger, is important for providing robust debugging capabilities for Go users. It is deeply integrated with the Go team-maintained VS Code Go extension. However, Delve is currently excluded from Go telemetry, which limits insights into debug feature usage and trends.
Proposal
Expand Go telemetry to include Delve, enabling valuable insights into debugging behavior within VS Code Go and beyond, ultimately improving the user debugging experience. This involves
Current
Proposed update
Adding telemetry in Delve using the golang.org/x/telemetry/counter API. The API will record the measured counters to the files on the local computer. The Delve team decides what and how to measure. The Go team and other Delve integrators can propose addition of new metrics by filing feature requests in the delve issue tracker.
Adding Delve’s counters in the telemetry upload config, following the official telemetry proposal process. Once added, the Go command will find the counters from the files on the local computer and upload them to telemetry.go.dev.
Example metrics
Alternatives considered
Rationale
cc @derekparker @aarzilli @golang/tools-team @rsc