x/pkgsite: `X` is always visible on homepage search

[andybons]

What is the URL of the page with the issue?

https://pkg.go.dev

What is your user agent?

Chrome Mac

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36

Screenshot

What did you do?

Visited https://pkg.go.dev

What did you expect to see?

No X since nothing was in the search input

Additionally:

1. The letter ‘X’ shouldn’t be used as a “clear” icon. Use an actual icon or multiply (‘×’).
2. There’s a bottom border that doesn’t match the rest of the search bar. That should’t be there.
3. Hovering over the close icon causes a white border to appear on the right. That shouldn’t appear either.

What did you see instead?

An X

[gabyhelp]

Related Issues and Documentation

• x/pkgsite: pressing the 'X' button doesn't close the search dialogue #50895 (closed)
• x/pkgsite: "Search help" button is too conspicuous #40624 (closed)
• x/pkgsite: #68315 (closed)
• x/pkgsite: #65743 (closed)
• x/pkgsite: #57858 (closed)
• x/pkgsite: #57467 (closed)
• x/pkgsite: #57347 (closed)
• x/pkgsite: #54055 (closed)
• x/pkgsite: #53531 (closed)
• x/pkgsite: #53126 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[cespare]

I remember that this didn't used to be like this. I did a bisect and found that all of the issues mentioned here were introduced in CL 513037.

[hyangah]

cc @jba