golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
122.88k stars 17.52k forks source link

x/build/cmd/relui: dynamically respond to nested modules in monthly golang.org/x tagging workflow #68873

Open dmitshur opened 1 month ago

dmitshur commented 1 month ago

Issue #48523 was about tagging golang.org/x repos monthly, automatically.

It's been implemented for a while, but one area for improvement is that the relui workflow currently hard-codes extra directories that need to be tidied in some x/ repos because they have nested modules and/or replace directives (and in very very rare cases, there may be a workspace via a checked in go.work files). The relevant code:

https://cs.opensource.google/go/x/build/+/master:internal/task/tagx.go;l=393-404;drc=37c49bbfbc400bf05e0bc91b0042279a5220a2b9

This is the tracking issue to improve this to cause less overhead as golang.org/x repos evolve.

We already do the work of dynamically walking the repo tree to find nested modules e.g. when testing all golang.org/x repos (and their nested modules), see https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/go/src/infra/experimental/golangbuild/testmode.go;l=370-392;drc=d2899a13c5223f9c36cf236efae90ae0cecb684f. So that might come in handy.

CC @golang/release.

gabyhelp commented 1 month ago

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

gopherbot commented 1 month ago

Change https://go.dev/cl/605316 mentions this issue: internal/task: add oscar submodules to tagx