x/telemetry: download the upload config lazily

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

123.98k stars 17.67k forks source link

x/telemetry: download the upload config lazily #69262

Open findleyr opened 2 months ago

findleyr commented 2 months ago

This is a follow up to #68946. To fix that issue for go 1.23.1, we did the absolutely narrowest fix to suppress the telemetry config download if the telemetry mode is not "on".

However, we should also make the download lazy, so that we download the config once a week when there is actual work to upload, rather than once a day when the upload process runs.

We could also consider back-porting this fix to 1.23.2, as I think it will be a safe change.

gabyhelp commented 2 months ago

Related Issues and Documentation

x/telemetry: allow to use custom config download logic #67726

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}