build: amd64 builders don't support SHA extensions

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

124.29k stars 17.7k forks source link

build: amd64 builders don't support SHA extensions #69592

Open FiloSottile opened 2 months ago

FiloSottile commented 2 months ago

The amd64 builders don't support the SHA x86-64 extensions, so our crypto/sha256 assembly is untested, in violation of the Assembly Policy.

/cc @golang/security @golang/release

gopherbot commented 2 months ago

Change https://go.dev/cl/614656 mentions this issue: crypto/sha256,crypto/sha512: test fallback implementations

gabyhelp commented 2 months ago

Related Issues and Documentation

build: arm64 builders don't support SHA-512 extensions #69593

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

FiloSottile commented 1 month ago

@dr2chase not sure why this and #69593 are assigned to me? I think the next step is for @golang/release to figure out if we can select builders with more recent CPUs so we can test this code.