Soon, gomote repro is going to assume some logic in golangbuild as part of its test command output, specifically for the no-network builders. This is unfortunate, since we're duplicating this subtle logic in multiple places.
Let's strive to avoid that in the future. In particular, test execution in golangbuild has some complexity around test execution. The two biggest ones are disabling the network on some builders and copying nested submodules out of context to test them (#34352). It would make sense to turn golangbuild into its own reproducer, like we do for the environment. This could work but needs thought.
For now, this issue tracks this particular consequence of the complexity of test execution seeping into other parts of the codebase: duplicating the no-network logic for printing the test command in the gomote repro command.
dmitshur
commented
1 month ago
Soon,
gomote reprois going to assume some logic ingolangbuildas part of its test command output, specifically for the no-network builders. This is unfortunate, since we're duplicating this subtle logic in multiple places.Let's strive to avoid that in the future. In particular, test execution in
golangbuildhas some complexity around test execution. The two biggest ones are disabling the network on some builders and copying nested submodules out of context to test them (#34352). It would make sense to turngolangbuildinto its own reproducer, like we do for the environment. This could work but needs thought.For now, this issue tracks this particular consequence of the complexity of test execution seeping into other parts of the codebase: duplicating the no-network logic for printing the test command in the
gomote reprocommand.