x/build/cmd/watchflakes: fails to run after a build output property field gitilesCommit → gitiles_commit rename

[dmitshur]

Watchflakes is currently in a continuous crashloop:

$ kubectl logs -p watchflakes-deployment-7dd687d899-8rf75
watchflakes: 2024/09/24 12:12:43 ListBuilders  
watchflakes: 2024/09/24 12:12:44 ReadBoard go master
watchflakes: 2024/09/24 12:12:44 ListCommits go master
watchflakes: 2024/09/24 12:12:44 ListBuilders go master
watchflakes: 2024/09/24 12:12:45 GetBuilds gotip-linux-amd64-ssacheck
watchflakes: 2024/09/24 12:12:45 GetBuilds gotip-linux-386-softfloat
[...]
watchflakes: 2024/09/24 12:12:45 GetBuilds gotip-linux-386-longtest
watchflakes: 2024/09/24 12:12:45 GetBuilds gotip-js-wasm
watchflakes: 2024/09/24 12:12:45 GetBuilds gotip-linux-amd64-longtest-race
watchflakes: 2024/09/24 12:12:46 repo mismatch:  go https://ci.chromium.org/b/8735981222897055585

It keeps running into the log.Fatalf at luci.go:366.

The problem is likely related to the fact that the output property "sources" now has a field named "gitiles_commit", whereas previously that field was named "gitilesCommit", and watchflakes looks only for the previous name at this time.

For reference:

• build 8736245996583568945 from Sep 20 has "gitilesCommit"
• build 8736029737891541697 from Sep 23 has "gitiles_commit"

crrev.com/c/5875121 might be what caused the field to have a new underscore-separated name.

CC @golang/release, @dr2chase, @cherrymui.

[gabyhelp]

Related Issues and Documentation

• x/build: `both tag ("refs/heads/master") and branch ("master") set for ...` failure on subrepos #65551 (closed)
• build: build failure on x_tools-go1.21-darwin-amd64-nocgo #66899
• x/build/cmd/watchflakes: should report x/ repo breakage caused by Go repo change #68753
• build: build failure on x_tools-go1.22-linux-amd64-boringcrypto #66900
• build: golang.org/x/telemetry/crashmonitor failures #67448 (closed)
• build: golang.org/x/tools/gopls/internal/cmd failures #68193 (closed)
• build: golang.org/x/telemetry/internal/crashmonitor failures #67449 (closed)
• build: golang.org/x/telemetry/godev/internal/content failures #67898 (closed)
• build: build failure on x_tools-go1.22-windows-arm64 #67407
• build: golang.org/x/telemetry/internal/crashmonitor failures #68215 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}