go/ast: (*ast.BasicLit).End() is wrong for raw literals with carriage returns ('\r')

[mateusz834]

Same as #41197, but for *ast.BasicLit can happen for raw literal strings.

As per the go spec:

Carriage return characters ('\r') inside raw string literals are discarded from the raw string value.

The End pos is calculated as such:

https://github.com/golang/go/blob/b521ebb55a9b26c8824b219376c7f91f7cda6ec2/src/go/ast/ast.go#L528

We are not storing the end pos in the *ast.BasicLit, so it might be not accurate for raw string literals containing carriage returns.

I think that same as in #41197, we should only document that.

[gabyhelp]

Related Issues and Documentation

• go/ast: `(*ast.BasicLit).End()` is wrong for raw literals with carriage returns ('\r') #69860 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[mateusz834]

CC @griesemer @adonovan

[gopherbot]

Change https://go.dev/cl/619835 mentions this issue: go/ast: document invalid raw string literal end position containing carriage returns