crypto/rand: TestAllocations fails on plan9 since CL 602498

millerresearch commented 1 week ago

Go version

gotip plan9/arm

Output of `go env` in your module/workspace:

GO111MODULE=''
GOARCH='arm'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/usr/glenda/lib/cache/go-build'
GOENV='/usr/glenda/lib/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm'
GOHOSTOS='plan9'
GOINSECURE=''
GOMODCACHE='/usr/glenda/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='plan9'
GOPATH='/usr/glenda/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/boot/workdir/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/boot/workdir/go/pkg/tool/plan9_arm'
GOVCS=''
GOVERSION='gotip'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/usr/glenda/lib/go/telemetry'
GCCGO='gccgo'
GOARM='7,hardfloat'
AR='ar'
CC='5c'
CXX='g++'
CGO_ENABLED='0'
GOMOD='/boot/workdir/go/src/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -marm -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3624963771=/tmp/go-build -gno-record-gcc-switches'

What did you do?

go test crypto/rand

What did you see happen?

--- FAIL: TestAllocations (0.01s)
    rand_test.go:169: allocs = 3, want 0
FAIL
FAIL    crypto/rand 5.524s
FAIL

What did you expect to see?

When introduced in CL 602498 the test was skipped for GOOS aix and js because they could be expected to make allocations during this test. It appears the test should be skipped for plan9 for the same reason.

gabyhelp commented 1 week ago

Related Issues and Documentation

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

dmitshur commented 1 week ago

CC @golang/plan9, @FiloSottile.

golang / go