Open gopherbot opened 2 weeks ago
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestStdWorkspace/default"
This looks like a real data race in the the way gopls invokes the type checker. @findleyr
Yep. I'll fix.
While we haven't reproduced, it looks like this is a real (and longstanding) data race in go/types:
Note that in order for this race to be exercised, there must be two distinct packages type checked concurrently that dot-import the same third package, which is imported from export data. That may explain why we haven't seen this race in the past.
There are multiple potential fixes:
I think we should make both fixes. In the meantime, I'm not sure whether we can reasonably work around this in gopls.
I'll try to put together a minimal repro.
CC @griesemer @timothy-king
Change https://go.dev/cl/621637 mentions this issue: go/types,types2: avoid data race to object.color_ through dot imports
Change https://go.dev/cl/621855 mentions this issue: internal/gcimporter: work around go/types data race in 1.23.
Change https://go.dev/cl/622319 mentions this issue: internal/gcimporter: extend markBlack workaround go1.22
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestStdWorkspace/default"
(... long comment truncated ...)
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestStdWorkspace/default"
(... long comment truncated ...)
This latest batch of flakes is unrelated to this issue (not a data race); I have refined the watchflakes predicate. I'll split them into a separate issue (https://github.com/golang/go/issues/70187).
#!watchflakes default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestStdWorkspace/default" && `WARNING: DATA RACE`
Issue created automatically to collect these failures.
Example (log):
=== RUN TestStdWorkspace/default ================== WARNING: DATA RACE Read at 0x00c0151ed0cc by goroutine 59643: go/types.(*object).color() /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/object.go:163 +0x38 go/types.(*TypeName).color() <autogenerated>:1 +0x17 go/types.(*Checker).objDecl() /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/decl.go:90 +0x3dd ... [Trace - 14:04:41.470 PM] Received notification 'textDocument/publishDiagnostics'. Params: {"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/interface.go","version":1,"diagnostics":[]} [Trace - 14:04:41.940 PM] Received response 'textDocument/references - (3)' in 857ms. Result: [{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/ast.go","range":{"start":{"line":1040,"character":5},"end":{"line":1040,"character":9}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/ast.go","range":{"start":{"line":1056,"character":9},"end":{"line":1056,"character":13}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/ast.go","range":{"start":{"line":1060,"character":9},"end":{"line":1060,"character":13}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/ast.go","range":{"start":{"line":1075,"character":21},"end":{"line":1075,"character":25}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/ast.go","range":{"start":{"line":1091,"character":23},"end":{"line":1091,"character":27}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/ast.go","range":{"start":{"line":1096,"character":21},"end":{"line":1096,"character":25}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/commentmap.go","range":{"start":{"line":226,"character":8},"end":{"line":226,"character":12}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/filter.go","range":{"start":{"line":26,"character":22},"end":{"line":26,"character":26}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/filter.go","range":{"start":{"line":252,"character":21},"end":{"line":252,"character":25}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/filter.go","range":{"start":{"line":256,"character":21},"end":{"line":256,"character":25}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/filter.go","range":{"start":{"line":334,"character":54},"end":{"line":334,"character":58}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/filter.go","range":{"start":{"line":493,"character":9},"end":{"line":493,"character":13}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/filter_test.go","range":{"start":{"line":65,"character":26},"end":{"line":65,"character":30}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/import.go","range":{"start":{"line":15,"character":41},"end":{"line":15,"character":45}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/import.go","range":{"start":{"line":101,"character":39},"end":{"line":101,"character":43}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/resolve.go","range":{"start":{"line":76,"character":55},"end":{"line":76,"character":59}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/ast/walk.go","range":{"start":{"line":335,"character":7},"end":{"line":335,"character":11}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/build/build.go","range":{"start":{"line":1430,"character":17},"end":{"line":1430,"character":21}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/doc.go","range":{"start":{"line":207,"character":52},"end":{"line":207,"character":56}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/doc.go","range":{"start":{"line":228,"character":37},"end":{"line":228,"character":41}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/doc.go","range":{"start":{"line":229,"character":21},"end":{"line":229,"character":25}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/doc_test.go","range":{"start":{"line":104,"character":20},"end":{"line":104,"character":24}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/doc_test.go","range":{"start":{"line":160,"character":39},"end":{"line":160,"character":43}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example.go","range":{"start":{"line":27,"character":18},"end":{"line":27,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example.go","range":{"start":{"line":50,"character":32},"end":{"line":50,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example.go","range":{"start":{"line":152,"character":27},"end":{"line":152,"character":31}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example.go","range":{"start":{"line":152,"character":55},"end":{"line":152,"character":59}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example.go","range":{"start":{"line":320,"character":13},"end":{"line":320,"character":17}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example.go","range":{"start":{"line":545,"character":31},"end":{"line":545,"character":35}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example.go","range":{"start":{"line":545,"character":42},"end":{"line":545,"character":46}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example_test.go","range":{"start":{"line":90,"character":58},"end":{"line":90,"character":62}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example_test.go","range":{"start":{"line":129,"character":17},"end":{"line":129,"character":21}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example_test.go","range":{"start":{"line":261,"character":17},"end":{"line":261,"character":21}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/example_test.go","range":{"start":{"line":329,"character":63},"end":{"line":329,"character":67}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/exports.go","range":{"start":{"line":314,"character":38},"end":{"line":314,"character":42}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/doc/reader.go","range":{"start":{"line":561,"character":35},"end":{"line":561,"character":39}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/format/format.go","range":{"start":{"line":54,"character":15},"end":{"line":54,"character":19}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/format/format.go","range":{"start":{"line":57,"character":11},"end":{"line":57,"character":15}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/format/format.go","range":{"start":{"line":60,"character":27},"end":{"line":60,"character":31}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/format/format.go","range":{"start":{"line":116,"character":34},"end":{"line":116,"character":38}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/format/internal.go","range":{"start":{"line":23,"character":11},"end":{"line":23,"character":15}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/format/internal.go","range":{"start":{"line":95,"character":11},"end":{"line":95,"character":15}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/internal/gcimporter/gcimporter_test.go","range":{"start":{"line":244,"character":43},"end":{"line":244,"character":47}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/internal/srcimporter/srcimporter.go","range":{"start":{"line":164,"character":70},"end":{"line":164,"character":74}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/internal/srcimporter/srcimporter.go","range":{"start":{"line":171,"character":22},"end":{"line":171,"character":26}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/internal/srcimporter/srcimporter.go","range":{"start":{"line":200,"character":48},"end":{"line":200,"character":52}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/interface.go","range":{"start":{"line":83,"character":81},"end":{"line":83,"character":85}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/interface.go","range":{"start":{"line":111,"character":12},"end":{"line":111,"character":16}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/interface.go","range":{"start":{"line":167,"character":33},"end":{"line":167,"character":37}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/parser.go","range":{"start":{"line":2842,"character":34},"end":{"line":2842,"character":38}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/parser.go","range":{"start":{"line":2892,"character":11},"end":{"line":2892,"character":15}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/parser_test.go","range":{"start":{"line":359,"character":24},"end":{"line":359,"character":28}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/parser_test.go","range":{"start":{"line":392,"character":48},"end":{"line":392,"character":52}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/resolver.go","range":{"start":{"line":20,"character":27},"end":{"line":20,"character":31}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/parser/resolver_test.go","range":{"start":{"line":77,"character":31},"end":{"line":77,"character":35}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/nodes.go","range":{"start":{"line":1993,"character":32},"end":{"line":1993,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/performance_test.go","range":{"start":{"line":21,"character":15},"end":{"line":21,"character":19}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer.go","range":{"start":{"line":1062,"character":11},"end":{"line":1062,"character":15}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer.go","range":{"start":{"line":1082,"character":11},"end":{"line":1082,"character":15}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer.go","range":{"start":{"line":1131,"character":31},"end":{"line":1131,"character":35}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer.go","range":{"start":{"line":1170,"character":11},"end":{"line":1170,"character":15}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer_test.go","range":{"start":{"line":276,"character":38},"end":{"line":276,"character":42}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer_test.go","range":{"start":{"line":344,"character":19},"end":{"line":344,"character":23}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer_test.go","range":{"start":{"line":354,"character":23},"end":{"line":354,"character":27}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/printer/printer_test.go","range":{"start":{"line":580,"character":13},"end":{"line":580,"character":17}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api.go","range":{"start":{"line":320,"character":23},"end":{"line":320,"character":27}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api.go","range":{"start":{"line":473,"character":73},"end":{"line":473,"character":77}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":28,"character":53},"end":{"line":28,"character":57}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":45,"character":45},"end":{"line":45,"character":49}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":831,"character":42},"end":{"line":831,"character":46}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1005,"character":40},"end":{"line":1005,"character":44}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1238,"character":13},"end":{"line":1238,"character":17}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1443,"character":15},"end":{"line":1443,"character":19}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1446,"character":10},"end":{"line":1446,"character":14}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1447,"character":10},"end":{"line":1447,"character":14}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1474,"character":31},"end":{"line":1474,"character":35}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1509,"character":44},"end":{"line":1509,"character":48}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1686,"character":51},"end":{"line":1686,"character":55}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1715,"character":51},"end":{"line":1715,"character":55}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1848,"character":56},"end":{"line":1848,"character":60}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":1875,"character":44},"end":{"line":1875,"character":48}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2214,"character":30},"end":{"line":2214,"character":34}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2245,"character":51},"end":{"line":2245,"character":55}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2303,"character":50},"end":{"line":2303,"character":54}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2358,"character":17},"end":{"line":2358,"character":21}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2542,"character":44},"end":{"line":2542,"character":48}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2599,"character":50},"end":{"line":2599,"character":54}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2731,"character":48},"end":{"line":2731,"character":52}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/api_test.go","range":{"start":{"line":2956,"character":28},"end":{"line":2956,"character":32}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check.go","range":{"start":{"line":159,"character":22},"end":{"line":159,"character":26}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check.go","range":{"start":{"line":160,"character":24},"end":{"line":160,"character":28}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check.go","range":{"start":{"line":305,"character":45},"end":{"line":305,"character":49}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check.go","range":{"start":{"line":342,"character":27},"end":{"line":342,"character":31}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check.go","range":{"start":{"line":408,"character":41},"end":{"line":408,"character":45}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check.go","range":{"start":{"line":429,"character":46},"end":{"line":429,"character":50}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check_test.go","range":{"start":{"line":62,"character":91},"end":{"line":62,"character":95}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check_test.go","range":{"start":{"line":63,"character":18},"end":{"line":63,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/check_test.go","range":{"start":{"line":222,"character":30},"end":{"line":222,"character":34}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/eval_test.go","range":{"start":{"line":170,"character":18},"end":{"line":170,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/eval_test.go","range":{"start":{"line":260,"character":42},"end":{"line":260,"character":46}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/eval_test.go","range":{"start":{"line":324,"character":51},"end":{"line":324,"character":55}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/example_test.go","range":{"start":{"line":36,"character":18},"end":{"line":36,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/example_test.go","range":{"start":{"line":129,"character":52},"end":{"line":129,"character":56}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/example_test.go","range":{"start":{"line":194,"character":44},"end":{"line":194,"character":48}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":99,"character":25},"end":{"line":99,"character":29}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":103,"character":31},"end":{"line":103,"character":35}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":111,"character":28},"end":{"line":111,"character":32}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":118,"character":33},"end":{"line":118,"character":37}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":128,"character":32},"end":{"line":128,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":131,"character":32},"end":{"line":131,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":132,"character":32},"end":{"line":132,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":133,"character":32},"end":{"line":133,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":136,"character":36},"end":{"line":136,"character":40}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":137,"character":36},"end":{"line":137,"character":40}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":138,"character":36},"end":{"line":138,"character":40}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":141,"character":24},"end":{"line":141,"character":28}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":146,"character":26},"end":{"line":146,"character":30}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":147,"character":26},"end":{"line":147,"character":30}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":151,"character":27},"end":{"line":151,"character":31}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":164,"character":33},"end":{"line":164,"character":37}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":166,"character":33},"end":{"line":166,"character":37}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":168,"character":33},"end":{"line":168,"character":37}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":173,"character":33},"end":{"line":173,"character":37}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":182,"character":33},"end":{"line":182,"character":37}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":229,"character":25},"end":{"line":229,"character":29}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":242,"character":28},"end":{"line":242,"character":32}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":257,"character":32},"end":{"line":257,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":270,"character":29},"end":{"line":270,"character":33}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":287,"character":29},"end":{"line":287,"character":33}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":299,"character":24},"end":{"line":299,"character":28}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":325,"character":24},"end":{"line":325,"character":28}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":343,"character":24},"end":{"line":343,"character":28}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":393,"character":25},"end":{"line":393,"character":29}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":416,"character":29},"end":{"line":416,"character":33}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":440,"character":31},"end":{"line":440,"character":35}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":466,"character":32},"end":{"line":466,"character":36}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/generate_test.go","range":{"start":{"line":481,"character":23},"end":{"line":481,"character":27}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":111,"character":48},"end":{"line":111,"character":52}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":158,"character":48},"end":{"line":158,"character":52}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":295,"character":48},"end":{"line":295,"character":52}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":326,"character":29},"end":{"line":326,"character":33}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":341,"character":23},"end":{"line":341,"character":27}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":424,"character":30},"end":{"line":424,"character":34}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":432,"character":30},"end":{"line":432,"character":34}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":435,"character":30},"end":{"line":435,"character":34}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":832,"character":52},"end":{"line":832,"character":56}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/issues_test.go","range":{"start":{"line":929,"character":38},"end":{"line":929,"character":42}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/methodset_test.go","range":{"start":{"line":150,"character":56},"end":{"line":150,"character":60}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/methodset_test.go","range":{"start":{"line":172,"character":42},"end":{"line":172,"character":46}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/named_test.go","range":{"start":{"line":111,"character":56},"end":{"line":111,"character":60}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/resolver_test.go","range":{"start":{"line":120,"character":18},"end":{"line":120,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/self_test.go","range":{"start":{"line":105,"character":56},"end":{"line":105,"character":60}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/self_test.go","range":{"start":{"line":111,"character":18},"end":{"line":111,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/stdlib_test.go","range":{"start":{"line":272,"character":46},"end":{"line":272,"character":50}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/stdlib_test.go","range":{"start":{"line":375,"character":18},"end":{"line":375,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typeset_test.go","range":{"start":{"line":57,"character":54},"end":{"line":57,"character":58}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/version.go","range":{"start":{"line":88,"character":50},"end":{"line":88,"character":54}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/internal/types/errors/codes_test.go","range":{"start":{"line":59,"character":43},"end":{"line":59,"character":47}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/internal/types/errors/codes_test.go","range":{"start":{"line":105,"character":45},"end":{"line":105,"character":49}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/align_test.go","range":{"start":{"line":78,"character":18},"end":{"line":78,"character":22}}},{"uri":"file:///home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/metrics/description_test.go","range":{"start":{"line":104,"character":43},"end":{"line":104,"character":47}}}] #### End Gopls Test Logs for "TestStdWorkspace/default" --- FAIL: TestStdWorkspace/default (36.96s)
Issue created automatically to collect these failures.
Example (log):
— watchflakes