Open mmatczuk opened 1 day ago
x/net v0.30.0
go env
Not important.
I configured http2.Server with
and caused PING to be lost.
The newly added support for lost PING in server:
if sc.pingSent { sc.vlogf("timeout waiting for PING response") sc.conn.Close() return }
https://cs.opensource.google/go/x/net/+/refs/tags/v0.30.0:http2/server.go;l=1047
vs
func (cc *ClientConn) closeForLostPing() { err := errors.New("http2: client connection lost") if f := cc.t.CountError; f != nil { f("conn_close_lost_ping") } cc.closeForError(err) }
https://cs.opensource.google/go/x/net/+/refs/tags/v0.30.0:http2/transport.go;l=1159
I expect to see
ErrorLog
CountError
conn_close_lost_ping
Related Issues and Documentation
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
Go version
x/net v0.30.0
Output of
go env
in your module/workspace:What did you do?
I configured http2.Server with
and caused PING to be lost.
What did you see happen?
The newly added support for lost PING in server:
https://cs.opensource.google/go/x/net/+/refs/tags/v0.30.0:http2/server.go;l=1047
vs
https://cs.opensource.google/go/x/net/+/refs/tags/v0.30.0:http2/transport.go;l=1159
What did you expect to see?
I expect to see
ErrorLog
called with lost ping messageCountError
called withconn_close_lost_ping