x/tools/gopls: "edit does not belong to syntax of package %q" bug in golang.Rename

[adonovan]

#!stacks
"bug.Reportf" && "golang.(*renamer).update:+45"

Issue created by stacks.

        pgf, ok := enclosingFile(r.pkg, item.node.Pos())
        if !ok {
            bug.Reportf("edit does not belong to syntax of package %q", r.pkg)
            continue
        }

This stack 4VHVlA was reported by telemetry:

• gopls/bug
• golang.org/x/tools/gopls/internal/util/bug.report:+35
• golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
• golang.org/x/tools/gopls/internal/golang.(*renamer).update:+45
• golang.org/x/tools/gopls/internal/golang.renameObjects:+31
• golang.org/x/tools/gopls/internal/golang.renameOrdinary:+99
• golang.org/x/tools/gopls/internal/golang.Rename:+18
• golang.org/x/tools/gopls/internal/server.(*server).Rename:+17
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+489
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
• golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
• golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
• runtime.goexit:+0

  golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

[gabyhelp]

Related Issues and Documentation

• x/tools/gopls: crash when renaming in a package using builtins with type parameters #52940 (closed)
• x/tools/gopls: rename crashes in objectpath #60789 (closed)
• x/tools/gopls: "inline: corrupted reference %v" bug in golang.RemoveUnusedParameter #69896
• x/tools/gopls: nil pointer on rename #32974 (closed)
• x/tools/gopls: crash during renaming #53277 (closed)
• x/tools/gopls: rename crashes on single segment import path #33768 (closed)
• x/tools/gopls: rename crashes on builtin types #32992 (closed)
• x/tools/gopls: Show specific file name when renaming failed. #69563 (closed)
• x/tools/gopls: rename panics if a test file exists #33664 (closed)
• x/tools/gopls/internal/regtest/misc: rename failures #56039 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}