Open prattmic opened 2 hours ago
#!watchflakes default <- pkg == "runtime/pprof" && test == "TestGenericsHashKeyInPprofBuilder"
This test failed in CI: https://ci.chromium.org/ui/p/golang/builders/try/gotip-linux-amd64-staticlockranking/b8732088109106960193/test-results?sortby=&groupby=
The problem is we got
testing.tRunner;runtime/pprof.TestGenericsHashKeyInPprofBuilder;runtime/pprof.genericAllocFunc[go.shape.uint32] [1 128 1 128]
but want
testing.tRunner;runtime/pprof.TestGenericsHashKeyInPprofBuilder;runtime/pprof.genericAllocFunc[go.shape.uint32] [1 128 0 0]
I think this is saying that the allocation is unexpectedly live. The 128 one at https://cs.opensource.google/go/go/+/master:src/runtime/pprof/protomem_test.go;l=132;drc=6f59c11155d75024985d4827a7fe155cd6561df9.
This test isn't intending to test liveness at all, so ignoring that field likely makes the most sense.
cc @golang/runtime
Related Issues and Documentation
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
This test failed in CI: https://ci.chromium.org/ui/p/golang/builders/try/gotip-linux-amd64-staticlockranking/b8732088109106960193/test-results?sortby=&groupby=
The problem is we got
but want
I think this is saying that the allocation is unexpectedly live. The 128 one at https://cs.opensource.google/go/go/+/master:src/runtime/pprof/protomem_test.go;l=132;drc=6f59c11155d75024985d4827a7fe155cd6561df9.
This test isn't intending to test liveness at all, so ignoring that field likely makes the most sense.
cc @golang/runtime