search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.07k stars 17.68k forks source link

x/tools/gopls/internal/test/integration/misc: TestRunGovulncheckStd/legacy=true/default failures #70355

Open gopherbot opened 5 hours ago

gopherbot commented 5 hours ago 
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRunGovulncheckStd/legacy=true/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestRunGovulncheckStd/legacy=true/default
panic: jsonrpc2.Async called multiple times

goroutine 79130 [running]:
golang.org/x/tools/internal/jsonrpc2.(*releaser).release(0x40092d3380, 0x40?)
    /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/internal/jsonrpc2/handler.go:147 +0xf8
golang.org/x/tools/internal/jsonrpc2.Async({0xfb6e48?, 0x400dc00af0?})
    /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/internal/jsonrpc2/handler.go:122 +0x58
golang.org/x/tools/gopls/internal/server.(*commandHandler).RunGovulncheck.func1({0xfb6e48, 0x400dc00af0}, {0x400d34fd40?, {0xfb9700?, 0x400d35d8c0?}, 0x400dc00b90?})
    /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:1316 +0x9c
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2()
    /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:381 +0x80
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func3()
    /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:405 +0x40
created by golang.org/x/tools/gopls/internal/server.(*commandHandler).run in goroutine 79204
    /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:404 +0x394

— watchflakes

gopherbot commented 5 hours ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRunGovulncheckStd/legacy=true/default"
2024-11-14 17:27 x_tools-gotip-netbsd-arm64 tools@a8d0fa56 go@672a53de x/tools/gopls/internal/test/integration/misc.TestRunGovulncheckStd/legacy=true/default [ABORT] (log) === RUN TestRunGovulncheckStd/legacy=true/default panic: jsonrpc2.Async called multiple times goroutine 79130 [running]: golang.org/x/tools/internal/jsonrpc2.(*releaser).release(0x40092d3380, 0x40?) /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/internal/jsonrpc2/handler.go:147 +0xf8 golang.org/x/tools/internal/jsonrpc2.Async({0xfb6e48?, 0x400dc00af0?}) /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/internal/jsonrpc2/handler.go:122 +0x58 golang.org/x/tools/gopls/internal/server.(*commandHandler).RunGovulncheck.func1({0xfb6e48, 0x400dc00af0}, {0x400d34fd40?, {0xfb9700?, 0x400d35d8c0?}, 0x400dc00b90?}) /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:1316 +0x9c golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2() /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:381 +0x80 golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func3() /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:405 +0x40 created by golang.org/x/tools/gopls/internal/server.(*commandHandler).run in goroutine 79204 /home/swarming/.swarming/w/ir/x/w/targetrepo1905921704/gopls/internal/server/command.go:404 +0x394

— watchflakes

gopherbot commented 5 hours ago

Change https://go.dev/cl/628236 mentions this issue: gopls/internal/server: remove spurious Async in legacy RunGoVulncheck