gopherbot
commented
6 days ago This PR (HEAD: ac6e99f73770ab3ea4a3efbc0af9d0a16f72d63d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628556.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Fixes #22816
JSON unmarshal can return an error type, UnmarshalTypeError, that contains very useful information such as the field that an error originated from. Unfortunately, this error type is not always returned and that information is not bubbled up during unmarshaling. This makes it difficult to return helpful API or CLI responses to users so they can correct invalid JSON.
This PR changes unmarshal to always wrap errors using this type. The behavior stays mostly the same:
Error()valueThis PR has the possibility of breaking error comparisons if folks are doing something like this:
As the err type will no longer be returned as the Unmarshal error but wrapped using UnmarshalTypeError. To work around this, users can do:
If this is too much of a breaking change, I would like to rework the PR into a new function that performs this new error behavior. Feedback welcome on what to call it, UnmarshalWithErr seems a bit wordy.