debug/dwarf: fail on reading incorrect offset due to skipped compilation unit

danipozo commented 4 days ago

Don't return incorrect offsets silently on Reader.Next(). Add SeekAndSetCU() method to set the CU before reading entries to prevent this failure. Would prevent and serve to fix go-delve/delve#3861 and parca-dev/parca#5291.

aarzilli commented 4 days ago

Shouldn't this be what Seek always does?

gopherbot commented 4 days ago

This PR (HEAD: e1ed146af8f3c57093a8ac652cdb80379b7a8ed1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628876.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

danipozo commented 4 days ago

Shouldn't this be what Seek always does?

Actually, I think I agree. Probably we should discuss that in Gerrit as it is where review is supposed to happen (?)

I'll check again on this tomorrow, let's also see if someone more familiar with this module weighs in.

gopherbot commented 4 days ago

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 4 days ago

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 4 days ago

Message from Jorropo:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 4 days ago

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-17T21:09:23Z","revision":"eb0f9d70b4cf57f2be81a9811b2b702d39c9f981"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 4 days ago

Message from Jorropo:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 4 days ago

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results):

go on master (change 628876)

Build or test failure, click here for results.

To reproduce, try gomote repro 8730988252090815825.

Additional links for debugging:

Output for go tool dist test -json [shard 3]

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 4 days ago

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 3 days ago

Message from Ian Lance Taylor:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

gopherbot commented 3 days ago

Message from Alessandro Arzilli:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628876. After addressing review feedback, remember to publish your drafts!

golang / go

debug/dwarf: fail on reading incorrect offset due to skipped compilation unit #70400