search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.21k stars 17.7k forks source link

x/tools/go/analysis/passes/copylock: Test failures #70426

Open gopherbot opened 3 days ago

gopherbot commented 3 days ago 
#!watchflakes
default <- pkg == "golang.org/x/tools/go/analysis/passes/copylock" && test == "Test"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test
    analysistest.go:550: a/copylock_func.go:14:15: diagnostic "BadFunc2 passes lock by value: sync.Map contains sync.noCopy" does not match pattern `BadFunc2 passes lock by value: sync.Map contains sync.Mutex`
    analysistest.go:550: a/copylock_func.go:21:21: diagnostic "func passes lock by value: sync.Map contains sync.noCopy" does not match pattern `func passes lock by value: sync.Map contains sync.Mutex`
    analysistest.go:548: a/copylock_func.go:136:7: unexpected diagnostic: Bad passes lock by value: a.LocalMutex contains sync.noCopy
    analysistest.go:614: a/copylock_func.go:14: no diagnostic was reported matching `BadFunc2 passes lock by value: sync.Map contains sync.Mutex`
    analysistest.go:614: a/copylock_func.go:21: no diagnostic was reported matching `func passes lock by value: sync.Map contains sync.Mutex`
--- FAIL: Test (4.71s)

— watchflakes

gopherbot commented 3 days ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/analysis/passes/copylock" && test == "Test"
2024-11-18 18:14 x_tools-gotip-darwin-amd64-race tools@a54bd37b go@80344887 x/tools/go/analysis/passes/copylock.Test (log) === RUN Test analysistest.go:550: a/copylock_func.go:14:15: diagnostic "BadFunc2 passes lock by value: sync.Map contains sync.noCopy" does not match pattern `BadFunc2 passes lock by value: sync.Map contains sync.Mutex` analysistest.go:550: a/copylock_func.go:21:21: diagnostic "func passes lock by value: sync.Map contains sync.noCopy" does not match pattern `func passes lock by value: sync.Map contains sync.Mutex` analysistest.go:548: a/copylock_func.go:136:7: unexpected diagnostic: Bad passes lock by value: a.LocalMutex contains sync.noCopy analysistest.go:614: a/copylock_func.go:14: no diagnostic was reported matching `BadFunc2 passes lock by value: sync.Map contains sync.Mutex` analysistest.go:614: a/copylock_func.go:21: no diagnostic was reported matching `func passes lock by value: sync.Map contains sync.Mutex` --- FAIL: Test (4.71s)
2024-11-18 19:30 x_tools-gotip-darwin-amd64-nocgo tools@acc2a741 go@5a0f2a7a x/tools/go/analysis/passes/copylock.Test (log) === RUN Test analysistest.go:550: unfortunate/local_go124.go:15:7: diagnostic "Bad passes lock by value: unfortunate.LocalOnce contains sync/atomic.Uint32 contains sync/atomic.noCopy" does not match pattern `Bad passes lock by value: unfortunate.LocalOnce contains sync.noCopy` analysistest.go:614: unfortunate/local_go124.go:15: no diagnostic was reported matching `Bad passes lock by value: unfortunate.LocalOnce contains sync.noCopy` analysistest.go:614: unfortunate/local_go124.go:19: no diagnostic was reported matching `Bad passes lock by value: unfortunate.LocalMutex contains sync.noCopy` --- FAIL: Test (1.75s)

— watchflakes

timothy-king commented 3 days ago

cc @mknyszek

From the log go on master ([commit 5a0f2a7](https://go.googlesource.com/go/+/5a0f2a7a7c5658f4f3065c265cee61ec1bde9691)). That is before https://go.dev/cl/627777 . I think we can wait for the flake to be closed.

mknyszek commented 3 days ago

Agreed. Apologies for the breakage. I'm somewhat surprised there was still potential for breakage here, but I suspect it's as simple as caches in Gerrit (or Gitiles, or something) didn't clear.

gopherbot commented 3 days ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/analysis/passes/copylock" && test == "Test"
2024-11-18 18:14 x_tools-gotip-linux-ppc64_power8 tools@a54bd37b go@8f223691 x/tools/go/analysis/passes/copylock.Test (log) === RUN Test analysistest.go:550: a/copylock_func.go:14:15: diagnostic "BadFunc2 passes lock by value: sync.Map contains sync.noCopy" does not match pattern `BadFunc2 passes lock by value: sync.Map contains sync.Mutex` analysistest.go:550: a/copylock_func.go:21:21: diagnostic "func passes lock by value: sync.Map contains sync.noCopy" does not match pattern `func passes lock by value: sync.Map contains sync.Mutex` analysistest.go:548: a/copylock_func.go:136:7: unexpected diagnostic: Bad passes lock by value: a.LocalMutex contains sync.noCopy analysistest.go:614: a/copylock_func.go:14: no diagnostic was reported matching `BadFunc2 passes lock by value: sync.Map contains sync.Mutex` analysistest.go:614: a/copylock_func.go:21: no diagnostic was reported matching `func passes lock by value: sync.Map contains sync.Mutex` --- FAIL: Test (1.79s)
2024-11-18 18:14 x_tools-gotip-linux-ppc64le_power8 tools@a54bd37b go@8f223691 x/tools/go/analysis/passes/copylock.Test (log) === RUN Test analysistest.go:550: a/copylock_func.go:14:15: diagnostic "BadFunc2 passes lock by value: sync.Map contains sync.noCopy" does not match pattern `BadFunc2 passes lock by value: sync.Map contains sync.Mutex` analysistest.go:550: a/copylock_func.go:21:21: diagnostic "func passes lock by value: sync.Map contains sync.noCopy" does not match pattern `func passes lock by value: sync.Map contains sync.Mutex` analysistest.go:548: a/copylock_func.go:136:7: unexpected diagnostic: Bad passes lock by value: a.LocalMutex contains sync.noCopy analysistest.go:614: a/copylock_func.go:14: no diagnostic was reported matching `BadFunc2 passes lock by value: sync.Map contains sync.Mutex` analysistest.go:614: a/copylock_func.go:21: no diagnostic was reported matching `func passes lock by value: sync.Map contains sync.Mutex` --- FAIL: Test (1.65s)

— watchflakes

adonovan commented 2 days ago

Seems to have calmed down.

gopherbot commented 18 hours ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/analysis/passes/copylock" && test == "Test"
2024-11-20 19:06 x_tools-gotip-darwin-arm64_11 tools@9dff42e5 go@2779e3a4 x/tools/go/analysis/passes/copylock.Test (log) === RUN Test analysistest.go:550: unfortunate/local_go124.go:15:7: diagnostic "Bad passes lock by value: unfortunate.LocalOnce contains sync/atomic.Uint32 contains sync/atomic.noCopy" does not match pattern `Bad passes lock by value: unfortunate.LocalOnce contains sync.noCopy` analysistest.go:614: unfortunate/local_go124.go:15: no diagnostic was reported matching `Bad passes lock by value: unfortunate.LocalOnce contains sync.noCopy` analysistest.go:614: unfortunate/local_go124.go:19: no diagnostic was reported matching `Bad passes lock by value: unfortunate.LocalMutex contains sync.noCopy` --- FAIL: Test (0.74s)
2024-11-20 19:06 x_tools-gotip-darwin-arm64_13 tools@9dff42e5 go@2779e3a4 x/tools/go/analysis/passes/copylock.Test (log) === RUN Test analysistest.go:550: unfortunate/local_go124.go:15:7: diagnostic "Bad passes lock by value: unfortunate.LocalOnce contains sync/atomic.Uint32 contains sync/atomic.noCopy" does not match pattern `Bad passes lock by value: unfortunate.LocalOnce contains sync.noCopy` analysistest.go:614: unfortunate/local_go124.go:15: no diagnostic was reported matching `Bad passes lock by value: unfortunate.LocalOnce contains sync.noCopy` analysistest.go:614: unfortunate/local_go124.go:19: no diagnostic was reported matching `Bad passes lock by value: unfortunate.LocalMutex contains sync.noCopy` --- FAIL: Test (0.89s)

— watchflakes

dmitshur commented 10 hours ago

Happened again in trybots for CL 629635 today (see build 8730612819953883601).