os: TestOpenError fails on some plan9 builders

[millerresearch]

Go version

gotip

Output of go env in your module/workspace:

AR='ar'
 CC='gcc'
 CGO_CFLAGS='-O2 -g'
 CGO_CPPFLAGS=''
 CGO_CXXFLAGS='-O2 -g'
 CGO_ENABLED='0'
 CGO_FFLAGS='-O2 -g'
 CGO_LDFLAGS='-O2 -g'
 CXX='g++'
 GCCGO='gccgo'
 GO111MODULE=''
 GO386='sse2'
 GOARCH='386'
 GOAUTH='netrc'
 GOBIN=''
 GOCACHE='/home/swarming/luci/386/.swarming/w/ir/x/w/gocache'
 GODEBUG=''
 GOENV='/home/swarming/luci/386/.config/go/env'
 GOEXE=''
 GOEXPERIMENT=''
 GOFLAGS=''
 GOGCCFLAGS='-fPIC -m32 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/home/swarming/luci/386/.swarming/w/ir/x/t/go-build2873492059=/tmp/go-build -gno-record-gcc-switches'
 GOHOSTARCH='amd64'
 GOHOSTOS='linux'
 GOINSECURE=''
 GOMOD='/dev/null'
 GOMODCACHE='/home/swarming/luci/386/.swarming/w/ir/x/w/gopath/pkg/mod'
 GONOPROXY=''
 GONOSUMDB=''
 GOOS='plan9'
 GOPATH='/home/swarming/luci/386/.swarming/w/ir/x/w/gopath'
 GOPRIVATE=''
 GOPROXY='https://proxy.golang.org,direct'
 GOROOT='/home/swarming/luci/386/.swarming/w/ir/x/w/goroot'
 GOSUMDB='sum.golang.org'
 GOTELEMETRY='local'
 GOTELEMETRYDIR='/home/swarming/luci/386/.config/go/telemetry'
 GOTMPDIR=''
 GOTOOLCHAIN='local'
 GOTOOLDIR='/home/swarming/luci/386/.swarming/w/ir/x/w/goroot/pkg/tool/linux_amd64'
 GOVCS=''
 GOVERSION='devel 400433af3660905ecaceaf19ddad3e6c24b141df'
 GOWORK=''
 PKG_CONFIG='pkg-config'

What did you do?

LUCI tests, for example ci/gotip-plan9-386

What did you see happen?

Example log:

=== RUN   TestOpenError
=== PAUSE TestOpenError
=== CONT  TestOpenError
    os_test.go:1830: Open("is-a-dir", 1) = _, "'/tmp/TestOpenError845272514/001/is-a-dir' permission denied"; want suffix "is a directory"
--- FAIL: TestOpenError (0.00s)

What did you expect to see?

Different Plan 9 file servers return different error strings (some arguably incorrect) when a process attempts to write to a directory. TestOpenError changed in CL 620157 to use a directory in /tmp instead of using the root file system. This may fail on Plan 9, depending on which file server is used to provide `/tmp'. The test already has a special case for Plan 9's idiosyncratic error messages, but needs to allow for more possibilities.

[gabyhelp]

Related Issues

• testing/fstest: test that ReadDir on file returns error, or returns 0 entries if file is empty #44967
• os: TestProgWideChdir failing on Plan 9 #10422 (closed)
• os: TestRemoveAllWithMoreErrorThanReqSize is failing on Plan 9 and Windows #35117 (closed)
• os: TestMkdirAll failing Plan 9 #23918 (closed)
• x/build: os.TestUserConfigDir and os.TestUserCacheDir failing on plan9-arm with `permission denied` #62216 (closed)
• x/tools/go/analysis/internal/checker: tests failing on Plan 9 because of dependence on numeric exit codes #68290 (closed)
• test: bug369 failing on Plan 9 #9428 (closed)
• x/tools/gopls/internal/regtest/misc: TestRenameFileFromEditor failures with `invalid argument` on plan9 #57111 (closed)
• testing: test failes if leaving files without write permission in T.TempDir #40853
• os: TestMkdirAll is broken on plan9 #23902 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/629635 mentions this issue: os: allow for variant plan9 error messages in TestOpenError