golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.21k stars 17.7k forks source link

weak: TestIssue69210 failures [1.23 backport] #70469

Closed gopherbot closed 1 day ago

gopherbot commented 1 day ago

@mknyszek requested issue #70455 to be considered for backport to the next 1.23 minor release.

@gopherbot Please open a backport issue for Go 1.23.

This bug causes rare and subtle crashes when using weak pointers (so, anything using unique and by extension, the net package). The fix is also simple and very safe.

gopherbot commented 1 day ago

Change https://go.dev/cl/630316 mentions this issue: [release-branch.go1.23] runtime: explicitly keep handle alive during getOrAddWeakHandle

gopherbot commented 1 day ago

Closed by merging CL 630316 (commit be062b7f61486db3c93741e794bd51eda5cc6fce) to release-branch.go1.23.