golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.21k stars 17.7k forks source link

x/tools/gopls/internal/test/marker: Test/fixedbugs/issue59944.txt failures #70482

Closed gopherbot closed 9 hours ago

gopherbot commented 1 day ago
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/fixedbugs/issue59944.txt
=== PAUSE Test/fixedbugs/issue59944.txt
=== CONT  Test/fixedbugs/issue59944.txt
    marker_test.go:259: cgo.go:16:7-8 (fixedbugs/issue59944.txt:31:7-8): unexpected diagnostic: "cannot define new methods on non-local type Layout"
--- FAIL: Test/fixedbugs/issue59944.txt (28.01s)

watchflakes

gopherbot commented 1 day ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 18:09 x_tools-gotip-darwin-amd64_11 tools@c1aa79d3 go@adc9c455 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:7-8 (fixedbugs/issue59944.txt:31:7-8): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (28.01s)
2024-11-20 18:09 x_tools-gotip-darwin-amd64_12 tools@c1aa79d3 go@adc9c455 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:7-8 (fixedbugs/issue59944.txt:31:7-8): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (6.97s)
2024-11-20 18:09 x_tools-gotip-linux-ppc64le_power9 tools@c1aa79d3 go@adc9c455 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:7-8 (fixedbugs/issue59944.txt:31:7-8): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (4.20s)

watchflakes

gopherbot commented 1 day ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 18:09 x_tools-gotip-linux-ppc64le_power8 tools@c1aa79d3 go@a9428eab x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:7-8 (fixedbugs/issue59944.txt:31:7-8): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (3.98s)

watchflakes

gopherbot commented 1 day ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 18:09 x_tools-gotip-darwin-amd64_13 tools@c1aa79d3 go@a9428eab x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:7-8 (fixedbugs/issue59944.txt:31:7-8): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (11.16s)

watchflakes

gopherbot commented 20 hours ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 18:09 x_tools-gotip-darwin-arm64_13 tools@c1aa79d3 go@a2a4f007 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:10-16 (fixedbugs/issue59944.txt:31:10-16): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (2.51s)

watchflakes

gopherbot commented 19 hours ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 18:09 x_tools-gotip-darwin-arm64_11 tools@c1aa79d3 go@a2a4f007 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:10-16 (fixedbugs/issue59944.txt:31:10-16): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (2.37s)
2024-11-20 18:09 x_tools-gotip-linux-loong64 tools@c1aa79d3 go@a2a4f007 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:10-16 (fixedbugs/issue59944.txt:31:10-16): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (5.75s)

watchflakes

gopherbot commented 18 hours ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 16:07 x_tools-gotip-darwin-arm64_11 tools@e7517567 go@a2a4f007 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:10-16 (fixedbugs/issue59944.txt:31:10-16): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (2.08s)
2024-11-20 18:09 x_tools-gotip-darwin-arm64_12 tools@c1aa79d3 go@a2a4f007 x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:10-16 (fixedbugs/issue59944.txt:31:10-16): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (1.90s)

watchflakes

gopherbot commented 17 hours ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 16:07 x_tools-gotip-darwin-arm64_13 tools@e7517567 go@28f4e14e x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:10-16 (fixedbugs/issue59944.txt:31:10-16): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (1.74s)

watchflakes

gopherbot commented 15 hours ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/fixedbugs/issue59944.txt"
2024-11-20 16:07 x_tools-gotip-darwin-arm64_12 tools@e7517567 go@28f4e14e x/tools/gopls/internal/test/marker.Test/fixedbugs/issue59944.txt (log) === RUN Test/fixedbugs/issue59944.txt === PAUSE Test/fixedbugs/issue59944.txt === CONT Test/fixedbugs/issue59944.txt marker_test.go:259: cgo.go:16:10-16 (fixedbugs/issue59944.txt:31:10-16): unexpected diagnostic: "cannot define new methods on non-local type Layout" --- FAIL: Test/fixedbugs/issue59944.txt (2.34s)

watchflakes

adonovan commented 9 hours ago

Looks like the compiler now rejects attempts to declare methods on cgo types C.T, so gopls doesn't need to. ... D'oh, @findleyr already fixed this yesterday in https://go.dev/cl/630117.